-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multithreaded loading of YAML databases #8119
base: master
Are you sure you want to change the base?
Conversation
While I can appreciate having some aspects of the emulator support multi threading, I'm not sure if the boot process is that necessary. As with compiling in debug mode vs release, running in debug mode will take longer. There's a lot of content that is being parsed so it makes sense that over the years load time would increase for renewal mode. Have you tried disabling this define? This should drastically improve the load time in debug mode as it won't spit out all the x/y parsing messages. |
DETAILED_LOADING_OUTPUT option does not reduce boot time outside of debug mode, this change is here for testing purposes only |
This small modification made reading YAML databases approximately 5% faster, I don't know if it will make any difference on extremely powerful computers, maybe difference can be greater, but on my humble phenom it made a considerable difference
my benchmark:
in ssd:
without async
with async
in harddisk
without async
with async
debug mode without async:
debug mode with async:
undefine loading output debug without async:
undefine loading output debug with async:
If you test it, let me know your times
accepting suggestions