Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for onCaughtError and onUncaughtError #6742

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

rickhanlonii
Copy link
Member

@rickhanlonii rickhanlonii commented Apr 9, 2024

Overview

In the React 19 canary we've added two new root options:

  • onCaughtError
  • onUncaughtError

This PR adds docs for how to use these new options to display an error dialog.

Additionally, this PR also:

  • Adds usage docs for the onRecoverableError option
  • Add error.cause to onRecoverableError docs

Preview

Copy link

vercel bot commented Apr 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
react-dev ✅ Ready (Inspect) Visit Preview Apr 11, 2024 0:56am

Copy link

github-actions bot commented Apr 9, 2024

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 103.9 KB (🟡 +7 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 79.88 KB (🟡 +152 B) 183.78 KB
/500 79.87 KB (🟡 +152 B) 183.78 KB
/[[...markdownPath]] 81.66 KB (🟡 +152 B) 185.56 KB
/errors 80.06 KB (🟡 +152 B) 183.96 KB
/errors/[errorCode] 80.03 KB (🟡 +152 B) 183.94 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

src/content/reference/react-dom/client/createRoot.md Outdated Show resolved Hide resolved
src/content/reference/react-dom/client/createRoot.md Outdated Show resolved Hide resolved
src/content/reference/react-dom/client/createRoot.md Outdated Show resolved Hide resolved
* **optional** `onRecoverableError`: Callback called when React automatically recovers from errors.
* <CanaryBadge title="This feature is only available in the Canary channel" /> **optional** `onCaughtError`: Callback called when React catches an error in an error boundary. Called with the `error` and an `errorInfo` object containing the `componentStack`.
* <CanaryBadge title="This feature is only available in the Canary channel" /> **optional** `onUncaughtError`: Callback called when an uncaught error is thrown. Called with the `error` and an `errorInfo` object containing the `componentStack`.
* **optional** `onRecoverableError`: Callback called when React automatically recovers from errors. Called with the `error` and an `errorInfo` object containing the `componentStack`. Some recoverable errors may include the original error cause as `error.cause`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we link to a section explaining what recovering from an error means in React?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have these docs, but we can add them as a followup.

src/content/reference/react-dom/client/createRoot.md Outdated Show resolved Hide resolved
src/content/reference/react-dom/client/createRoot.md Outdated Show resolved Hide resolved
src/content/reference/react-dom/client/hydrateRoot.md Outdated Show resolved Hide resolved
src/content/reference/react-dom/client/createRoot.md Outdated Show resolved Hide resolved
@MatanBobi
Copy link
Contributor

@eps1lon - Are these two functionalities we'd want to support in React Testing Library?

@rickhanlonii rickhanlonii merged commit db2dc7f into reactjs:main Apr 11, 2024
4 checks passed
@rickhanlonii rickhanlonii deleted the rh/root-options branch April 11, 2024 12:59
@eps1lon
Copy link
Collaborator

eps1lon commented Apr 11, 2024

Yeah definitely. Should be straight forward. But something to discuss on the RTL repo instead.

rickhanlonii added a commit to acdlite/reactjs.org that referenced this pull request Apr 17, 2024
* Add docs for onCaughtError and onUncaughtError

* Updates from feedback
rickhanlonii added a commit that referenced this pull request Apr 22, 2024
* API docs for useDeferredValue's initialValue

Updates the API docs for `useDeferredValue` to include the
`initialValue` option, added in
facebook/react#27500.

This feature is slated for release in React 19.

* Add docs for onCaughtError and onUncaughtError (#6742)

* Add docs for onCaughtError and onUncaughtError

* Updates from feedback

* Add canary info, simplify a bit

---------

Co-authored-by: Ricky <rickhanlonii@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants