Fix "Blocking Mono Result" example #3599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The provided example does not compile for two reasons:
- no matching `Mono.zip()` signature that accepts two `Publishers` (just `Mono`s)
- no `Flux#delay` anymore
Replaced the example with a more idiomatic usage - `Mono.delay()` followed by `then()` instead of `Mono.just()` followed by argument-discarding `map()`
|
@pivovarit Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
1 similar comment
|
@pivovarit Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@pivovarit Thank you for signing the Contributor License Agreement! |
chemicL
approved these changes
May 24, 2024
There was a problem hiding this comment.
Thanks for the PR @pivovarit :) I know it has been open for some time but I finally got to it and it is still helpful so I'll merge it now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The provided example did not compile for two reasons:
Mono.zip()signature that accepts twoPublishers(justMonos)Flux#delayanymoreReplaced the example with a more idiomatic usage -
Mono.delay()followed bythen()instead ofMono.just()followed by argument-discardingmap(). I allowed myself to replacecurrentTimeMilliswithInstants so that it's easier to see the difference when printed out