Draft: New: ignoreZeroSegments prop on pie #4107
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A Problem: When rendering segments of a pie that contain a "0" value, the lint error
react/no-array-index-key
appears.This solution: provide recharts consumers the ability to "tell" recharts to "skip" rendering segments of a pie where the value(s) are zero:
Also, this address some unforeseen lint issues in the pie "demo" file.
Related Issue
4004
Motivation and Context
One way forward out of the index-based keys currently in use in recharts.
If this seems like a plausible addition, this same prop could be added to many (all?) other chart types where "0" values may cause index-based-key errors.
How Has This Been Tested?
...tbd...
Breaking change (fix or feature that would cause existing functionality to change)Checklist: