Add badges #2096
Merged
Add badges #2096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelgfierro
requested review from
gramhagen,
anargyri,
loomlike,
wutaomsft and
SimonYansenZhao
as code owners
|
I would suggest the 'slack|join' badge/button be placed under the recommenders logo or be bigger so that people can notice there is a slack channel they can join. @miguelgfierro |
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
anargyri
approved these changes
May 14, 2024
|
The slack badge is a bit misaligned when I open the front page on my PC. Maybe move it to the next line? |
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
|
Now it looks better 👍 |
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
|
@anargyri the one with slack at the level of Recommenders or this one: |
|
I think this one is even better |
|
Another thing: we don't really need the title "Recommenders" if we have the logo that says the same thing, do we? It is a repetition. |
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
|
I like it more without Recommenders repeated. Looks nice! What do you think @SimonYansenZhao? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
References
Checklist:
git commit -s -m "your commit message".staging branchAND NOT TOmain branch.