mvlog/tests: clean up files in test body #18554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/49254#018f83ed-4340-4565-ae55-1f44fad67b12 |
I noticed that death tests were leaving behind some directories, even though the test appears to be exiting successfully. It turns out that because death tests run a separate process[1], it was creating an extra directory, but not running the teardown because of the process crash. So this hacks the tests to clean up in the test body before the crash. [1] https://github.com/google/googletest/blob/main/docs/advanced.md#death-tests-and-threads
andrwng
force-pushed
the
mvlog-file-cleanup
branch
from
4c281f0
to
0e2710f
Compare
andrwng
changed the title
nvartolomei
approved these changes
May 20, 2024
| ss::future<> TearDownAsync() override { | ||
| for (auto& file : files_) { | ||
| co_await file->close(); | ||
| } | ||
| co_await ss::recursive_remove_directory( | ||
| std::filesystem::path{base_dir_}); | ||
| // NOTE: death tests may clean themselves up in the test body to avoid |
There was a problem hiding this comment.
"may clean" or "may need to clean"?
There was a problem hiding this comment.
Yeah it should be "need to". Can follow up if you think it's unclear enough to trip up on
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that death tests were leaving behind some directories, even
though the test appears to be exiting successfully.
It turns out that because death tests run a separate process[1], it was
creating an extra directory, but not running the teardown because of the
process crash.
So this hacks the tests to clean up in the test body before the crash.
[1] https://github.com/google/googletest/blob/main/docs/advanced.md#death-tests-and-threads
Backports Required
Release Notes