CORE-2425 add additional tls error codes #18564
Conversation
michael-redpanda
requested review from
a team,
aanthony-rp and
oleiman
and removed request for
a team
src/v/net/connection.cc
Outdated
| @@ -27,22 +25,21 @@ namespace net { | |||
| * indirectly as errors from the TLS layer. | |||
| */ | |||
| bool is_reconnect_error(const std::system_error& e) { | |||
| auto v = e.code().value(); | |||
| const auto v = e.code().value(); | |||
| const std::array ss_tls_reconnect_errors{ | |||
Switched to using the error codes exposed from Seastar. This allows us to switch from GnuTLS to OpenSSL as the backend TLS provider in Seastar. Signed-off-by: Michael Boquard <michael@redpanda.com>
Signed-off-by: Michael Boquard <michael@redpanda.com>
michael-redpanda
force-pushed
the
CORE-2425-Add-additional-tls-error-codes
branch
from
a97dccc
to
1d60df7
Compare
|
Force push
|
|
Re-run of CI failed runs passed |
There was a problem hiding this comment.
change makes sense, updating to a new list of error codes and removing the switch/case. this particular change is about detecting a retry situation and there's no issue here. Are we returning new error codes from the API with this change? Will that be a breaking change for customers, potentially?
With one exception (which I'll discuss after this), these are the same error codes we were looking for as reconnect errors. (You can see the linked Seastar PR). The new one is the
If anything this may improve reliability. |
Removes use of GnuTLS from
net. Uses instead the error codes exposed from Seastar.Backports Required
Release Notes