Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: polymorphic components test #1880

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Conversation

whawker
Copy link
Collaborator

@whawker whawker commented Sep 24, 2022

Description

Experimenting reducing code duplication with polymorphic components

Checklist

  • I have read the contributing document.
  • My code follows the code style of this project and pnpm fix completed successfully.
  • I have updated the documentation where necessary.
  • New code is unit tested and all current tests pass when running pnpm test.

Screenshots

@changeset-bot
Copy link

changeset-bot bot commented Sep 24, 2022

⚠️ No Changeset found

Latest commit: 4517ac1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added framework: react ⚛️ Any changes to packages which are exclusively used for react code bases. type: ui 💅 Changes made to user facing components and styles. labels Sep 24, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 24, 2022

Deploy preview for remirror ready!

✅ Preview
https://remirror-hpn0lusd1-ocavue.vercel.app
https://pr1880-remirror-ocavue.vercel.app

Built with commit 4517ac1.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link
Contributor

github-actions bot commented Sep 24, 2022

🚀 Deployed on https://1880-merge--remirror.netlify.app

@github-actions github-actions bot temporarily deployed to pull request September 24, 2022 22:09 Inactive
@github-actions github-actions bot added package: @remirror/cli 📟 A label for the remirror cli. type: support 📚 A change focused on improving the architecture and structure of the support directory. labels Sep 26, 2022
@github-actions github-actions bot temporarily deployed to pull request September 26, 2022 15:16 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 26, 2022 15:56 Inactive
@ocavue
Copy link
Member

ocavue commented Sep 27, 2022

The generated code looks good to me.

For faster build speed, we can remove the postbuild (Prettier) script and just ignore these generated files from Prettier (and/or ESLint).

(Idea: we can create our own file name pattern for generated files, like xxx.gen.ts. Then we can just add *.gen.ts into .eslintignore / .prettierignore)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework: react ⚛️ Any changes to packages which are exclusively used for react code bases. package: @remirror/cli 📟 A label for the remirror cli. type: support 📚 A change focused on improving the architecture and structure of the support directory. type: ui 💅 Changes made to user facing components and styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants