Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: yjs undoManager is not working properly after updating editor #2127

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shlroland
Copy link
Contributor

@shlroland shlroland commented Jul 19, 2023

Description

detailed reason for this pr

yjs/y-prosemirror#114 and yjs/y-prosemirror#102

The implementation of this method is inspired by tiptap.
https://github.com/ueberdosis/tiptap/blob/bdc51d12b513e8d395e2aefa52ad890e4f2478a7/packages/extension-collaboration/src/collaboration.ts#L108

Checklist

  • I have read the contributing document.
  • My code follows the code style of this project and pnpm fix completed successfully.
  • I have updated the documentation where necessary.
  • New code is unit tested and all current tests pass when running pnpm test.

Screenshots

@changeset-bot
Copy link

changeset-bot bot commented Jul 19, 2023

⚠️ No Changeset found

Latest commit: 54c11d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@shlroland
Copy link
Contributor Author

@ocavue could you review this pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants