Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix downloading of lerobot dataset #3

Merged
merged 6 commits into from
May 16, 2024

Conversation

02alexander
Copy link
Collaborator

Copy link
Member

@jleibs jleibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is pip installing from the git url the right way to install? Is it not available as a pypi package?

@02alexander
Copy link
Collaborator Author

lerobot exists as a package on pypi, but it's one month old and it doesn't have lerobot.common.datasets.video_utils which we need.

@02alexander
Copy link
Collaborator Author

02alexander commented May 10, 2024

In the lerobot repository README they only mention installation via git, so I think that is the preferred option.

@02alexander
Copy link
Collaborator Author

I discovered another problem, right now we only get the path to the video + timestamp.
hugginface_video_file_issue

@02alexander
Copy link
Collaborator Author

02alexander commented May 12, 2024

@jleibs The lerobot datasets (version >= 1.2) are a bit complicated to download since the images are stored in a separate video files that needs to be downloaded, so I decided to let the lerobot package (via git) handle downloading of the dataset. One downside of doing it this way is that lerobot is a huge dependency, but now it should still work even if they update how the dataset is stored.

@02alexander 02alexander requested a review from jleibs May 12, 2024 15:33
@02alexander 02alexander merged commit 7e5febf into main May 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants