Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some static data to the store dump test suite #6167

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Add some static data to the store dump test suite #6167

merged 1 commit into from
Apr 30, 2024

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Apr 30, 2024

I cannot reproduce #6094, see #6094 (comment):

I actually cannot repro this. I tried:

  • Saving entire timeline, 0.15.1
  • Saving time selection, 0.15.1
  • Saving entire timeline, main
  • Saving time selection, main

For now the best I can think of is to add some static data to the test suite and call it a day...

Marking as do not merge until the situation is clarified.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@teh-cmc teh-cmc added 🔨 testing testing and benchmarks ⛃ re_datastore affects the datastore itself do-not-merge Do not merge this PR exclude from changelog PRs with this won't show up in CHANGELOG.md and removed do-not-merge Do not merge this PR labels Apr 30, 2024
@teh-cmc teh-cmc merged commit c672f98 into main Apr 30, 2024
34 of 39 checks passed
@teh-cmc teh-cmc deleted the cmc/6094 branch April 30, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md ⛃ re_datastore affects the datastore itself 🔨 testing testing and benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

static components doesn't roundtrip when saved to .rrd file
2 participants