Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix silently interpreting zero time range as latest-at query #6172

Merged
merged 5 commits into from
Apr 30, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Apr 30, 2024

What

plus (and that's the bigger part of this PR) refactor time range handling to remove old VisibleHistory rust types.
Commit by commit review recommended.

Still need to fix the ui to better communicate when latest-at is used.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself include in changelog labels Apr 30, 2024
Copy link

github-actions bot commented Apr 30, 2024

Deployed docs

Commit Link
fd3f006 https://landing-rfoiglwge-rerun.vercel.app/docs

@jleibs jleibs self-requested a review April 30, 2024 14:59
@Wumpf Wumpf added the do-not-merge Do not merge this PR label Apr 30, 2024
@Wumpf
Copy link
Member Author

Wumpf commented Apr 30, 2024

looks like I broke something. arkitscenes doesn't show its mesh anymore

@Wumpf
Copy link
Member Author

Wumpf commented Apr 30, 2024

already broken on main
#6175

@Wumpf Wumpf removed the do-not-merge Do not merge this PR label Apr 30, 2024
@Wumpf Wumpf merged commit e39a8cf into main Apr 30, 2024
40 of 42 checks passed
@Wumpf Wumpf deleted the andreas/fix-silent-latest-at branch April 30, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working include in changelog 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zero-lengthed visible time ranges shouldn't silently fall back to latest-at
2 participants