Add a new CLI option / spawn options to hide the welcome screen #6262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleibs
added
include in changelog
🪵 Log-API
abey79
approved these changes
May 10, 2024
| @@ -4,6 +4,10 @@ mod welcome_section; | |||
| use example_section::{ExampleSection, MIN_COLUMN_WIDTH}; | |||
| use welcome_section::welcome_section_ui; | |||
|
|
|||
| use crate::app_state::WelcomeScreenState; | |||
|
|
|||
| use super::no_data_ui; | |||
There was a problem hiding this comment.
For reason that will become apparent in my UI fixup pr, I think no_data_ui is better moved insde welcome_screen. I'll do that in that PR.
|
Would it make sense to add a GET arg for |
5 tasks
abey79
added a commit
that referenced
this pull request
May 10, 2024
### What Follow-up of #6262 to improve the default UI when the welcome screen is disabled and no recordings are loaded. - Fixes #6263 <img width="1522" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/ce7355e3-2aad-4171-9187-cda18df8aeaa"> ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6287?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6287?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/6287) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
We still need to also tackle #6263 since the place-holder UI isn't great.
Details
Handling this via blueprint is awkward since the welcome screen presentation happens without respect to any given blueprint, or in cases when all the recordings and their blueprints have been closed.
I decided adding this as a spawn option makes the most sense, since this is the context where someone knows how they are embedding Rerun in another application.
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerTo run all checks from
main, comment on the PR with@rerun-bot full-check.