test(connector): test postgres source and sink recovery #16765
Conversation
|
|
||
| sleep 10s | ||
|
|
||
| query I |
There was a problem hiding this comment.
This is where it fails, because at this point the CN has segfaulted, and we can't run queries.
There was a problem hiding this comment.
I didn't find the ci pipeline you run the test.
Wed May 15 07:03:17 UTC 2024 [risedev]: Program exited with 139
Probably you are using openjdk 11 in your mac, please use java 17
There was a problem hiding this comment.
I just ran it locally.
There was a problem hiding this comment.
Okay let me try it with java 17.
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 9425213 | Triggered | Generic Password | 70c5e94 | e2e_test/sink/recovery/pg.slt | View secret |
| 9425213 | Triggered | Generic Password | 70c5e94 | e2e_test/sink/recovery/pg.slt | View secret |
| 9425213 | Triggered | Generic Password | 70c5e94 | e2e_test/sink/recovery/pg.slt | View secret |
| 9425213 | Triggered | Generic Password | 70c5e94 | e2e_test/sink/recovery/pg.slt | View secret |
| 9425213 | Triggered | Generic Password | 9172c38 | e2e_test/sink/recovery/pg.slt | View secret |
| 9425213 | Triggered | Generic Password | 9172c38 | e2e_test/sink/recovery/pg.slt | View secret |
| 9425213 | Triggered | Generic Password | 9172c38 | e2e_test/sink/recovery/pg.slt | View secret |
| 9425213 | Triggered | Generic Password | 0313c75 | e2e_test/sink/recovery/pg.slt | View secret |
| 9425213 | Triggered | Generic Password | 0f03c93 | e2e_test/sink/recovery/pg.slt | View secret |
| 9425213 | Triggered | Generic Password | 5c6627c | e2e_test/sink/recovery/pg.slt | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Looks like if we do a series of recovery, CN segfaults.
In production I suppose we will apply recovery. But CN should not segfault in the first place.
CN log:
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.