Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sink): support delta lake checkpoint decouple #16777

Merged
merged 4 commits into from
May 21, 2024

Conversation

xxhZs
Copy link
Contributor

@xxhZs xxhZs commented May 16, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Borrowing iceberg related logic to implement delta lake checkpoint decouple
#16546

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

we can use it like :
create sink xxx with(commit_checkpoint_interval = 10);
then, we will synchronize downstream every ten barriers

@xxhZs xxhZs requested review from ZENOTME and wenym1 May 16, 2024 08:00
Copy link
Contributor

@wenym1 wenym1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xxhZs xxhZs added this pull request to the merge queue May 21, 2024
Merged via the queue into main with commit 3d58cc7 May 21, 2024
31 of 32 checks passed
@xxhZs xxhZs deleted the xxh/add-decouple-deltalake branch May 21, 2024 06:34
@hzxa21 hzxa21 added the user-facing-changes Contains changes that are visible to users label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants