Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing specified meta backend for backwards compat test config #16797

Merged
merged 4 commits into from
May 17, 2024
Merged

fix: missing specified meta backend for backwards compat test config #16797

merged 4 commits into from
May 17, 2024

Conversation

yezizp2012
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Fix #16794 .

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@github-actions github-actions bot added the type/fix Bug fix label May 17, 2024
@yezizp2012 yezizp2012 added the ci/run-backwards-compat-tests Run backwards compatibility tests in your PR. label May 17, 2024
xxchan
xxchan approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@yezizp2012 yezizp2012 enabled auto-merge May 17, 2024 03:38
@kwannoel
Copy link
Contributor

kwannoel commented May 17, 2024 •
edited

Pushed another commit to fix it, looks like the test still fails, since older version's risedev doesn't know how to handle meta-backend setting.

@yezizp2012
Copy link
Contributor Author

Pushed another commit to fix it, looks like the test still fails, since older version's risedev doesn't know how to handle meta-backend setting.

Thx, LGTM!

@yezizp2012
Copy link
Contributor Author

yezizp2012 commented May 17, 2024 •
edited

🥵 Found that #16662 is not included in release-1.9.

@yezizp2012 yezizp2012 mentioned this pull request May 17, 2024
Merged
9 tasks
@yezizp2012 yezizp2012 added this pull request to the merge queue May 17, 2024
Any commits made after this event will not be merged.
Merged via the queue into main with commit 347e186 May 17, 2024
28 of 29 checks passed
@yezizp2012 yezizp2012 deleted the fix/backwards-compat-test branch May 17, 2024 07:46
@yezizp2012 yezizp2012 added the need-cherry-pick-release-1.9 Open a cherry-pick PR to branch release-1.8 after the current PR is merged label May 17, 2024
github-actions bot pushed a commit that referenced this pull request May 17, 2024
@yezizp2012 @kwannoel
fix: missing specified meta backend for backwards compat test config (#…
bec63ff 
…16797)

Co-authored-by: Noel Kwan <noelkwan1998@gmail.com>
@github-actions github-actions bot mentioned this pull request May 17, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request May 17, 2024
@github-actions @yezizp2012 @kwannoel
fix: missing specified meta backend for backwards compat test config (#…
9749037 
…16797) (#16808)

Co-authored-by: August <pin@singularity-data.com>
Co-authored-by: Noel Kwan <noelkwan1998@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xxchan xxchan xxchan approved these changes

@kwannoel kwannoel Awaiting requested review from kwannoel

Assignees
No one assigned
Labels
ci/run-backwards-compat-tests Run backwards compatibility tests in your PR. need-cherry-pick-release-1.9 Open a cherry-pick PR to branch release-1.8 after the current PR is merged type/fix Bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flaky test: backwards compat test: Data directory is already used by another cluster
3 participants
@yezizp2012 @kwannoel @xxchan