-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: flip sourceID and originalSourceID in replay events for transformations #4593
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4593 +/- ##
==========================================
- Coverage 74.67% 74.33% -0.34%
==========================================
Files 406 406
Lines 48066 48090 +24
==========================================
- Hits 35891 35749 -142
- Misses 9867 10008 +141
- Partials 2308 2333 +25 ☔ View full report in Codecov by Sentry. |
processor/transformer/transformer.go
Outdated
@@ -342,6 +353,12 @@ func (trans *handle) transform( | |||
// Transform is one to many mapping so returned | |||
// response for each is an array. We flatten it out | |||
for _, transformerResponse := range batch { | |||
// flip back sourceID and original sourceID | |||
if transformerResponse.Metadata.OriginalSourceID != "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we should do this, there's a possibility that this data undergoes updates during the transformation, which could impact its reliability for our purposes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree.
The same pattern is being used for messageID
in several other places in processor too.
Maybe that's something we should take a look at too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just found out metadata can't be updated in a user transformation, so should be a non-issue.
9444f5d
to
41897ee
Compare
This PR is considered to be stale. It has been open 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR. |
Description
Flip the
SourceID
andOriginalSourceID(if != "")
before transformations and back after.Linear Ticket
< Replace with Linear Link >
Security