Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix doc:RssReader import path error #13143

Closed
wants to merge 1 commit into from

Conversation

waveBoom
Copy link

Description

i use the class RssReader when i use old llama_index
now my code change to use the new llama_index, RssReader path error
when i read the document i find the example error (https://docs.llamaindex.ai/en/stable/examples/data_connectors/WebPageDemo/?h=rssrea#using-rssreader)
so i
Fix the import path in docs/examples/data_connectors/WebPageDemo.ipynb

Fixes #10274

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new warnings

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 28, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@logan-markewich logan-markewich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import is correct.

Notice at the top there is a specific install for llama-index-readers-web

@logan-markewich
Copy link
Collaborator

Every integration is a package 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Documentation]: WebPageDemo.ipynb error: import path seems to be incorrect
2 participants