Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpt4o notebook over tesla impact docs #180

Merged
merged 6 commits into from
May 16, 2024
Merged

gpt4o notebook over tesla impact docs #180

merged 6 commits into from
May 16, 2024

Conversation

jerryjliu
Copy link
Contributor

No description provided.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -0,0 +1,373 @@
{
Copy link
Contributor

@hexapode hexapode May 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

20 -> 200


Reply via ReviewNB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@@ -0,0 +1,373 @@
{
Copy link
Contributor

@hexapode hexapode May 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By turning on gpt4o, we use GPT-4o multimodal capabilities to do document parsing per page.

By turning on gpt4o, we use GPT-4o multimodal capabilities to do document parsing per page instead of the LlamaParse normal pipeline.


Reply via ReviewNB

@@ -0,0 +1,373 @@
{
Copy link
Contributor

@hexapode hexapode May 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #5.    splitter = SentenceSplitter()

Should we do a page splitter?


Reply via ReviewNB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could write simple code in the notebook, but i'd prefer to have a module in the framework or the llamaparse client lib actually

e.g. LlamaParsePageSplitter

@jerryjliu
Copy link
Contributor Author

making some changes right now

@jerryjliu jerryjliu requested a review from hexapode May 14, 2024 18:37
@jerryjliu jerryjliu merged commit 0d2ad9f into main May 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants