New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Unsafe to Safety #125077
Rename Unsafe to Safety #125077
Conversation
rustbot has assigned @petrochenkov. Use |
Some changes occurred in need_type_info.rs cc @lcnr Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt Some changes occurred in compiler/rustc_codegen_gcc Some changes occurred in src/librustdoc/clean/types.rs cc @camelid Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt Some changes occurred in src/tools/clippy cc @rust-lang/clippy This PR changes Stable MIR cc @oli-obk, @celinval, @ouz-a HIR ty lowering was modified cc @fmease changes to the core type system |
r? @cjgillot |
516dffb
to
6922a2c
Compare
This comment has been minimized.
This comment has been minimized.
I'm going to wait on a review and decision about this or #124455 or any other alternative before fixing CI and possible conflicts as it is a lot of work to keep all these in a mergeable state. |
☔ The latest upstream changes (presumably #125179) made this pull request unmergeable. Please resolve the merge conflicts. |
27f1aee
to
ffa3007
Compare
This comment has been minimized.
This comment has been minimized.
ffa3007
to
80a395e
Compare
rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead. cc @rust-lang/rust-analyzer |
0ecc00d
to
134936e
Compare
134936e
to
6b46a91
Compare
r? jackh726 @bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (eb1a5c9): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 3.3%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 5.2%, secondary 6.3%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 669.868s -> 667.962s (-0.28%) |
Alternative to #124455, which is to just have one Safety enum to use everywhere, this opens the posibility of adding
ast::Safety::Safe
that's useful for unsafe extern blocks.This leaves us today with:
We would convert from
ast::Safety::Default
into the right Safety level according the context.