Attempt to add support for proxying updates and other HTTP requests - Request for Feedback - Do Not Merge #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…updates and other HTTP requests; Attempting to add config option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm attempting to add support for configuring an HTTP/SOCKS proxy for updates and other HTTP requests sent by portmaster.
I have succeeded in getting this to work with a hard-coded string by modifying portbase in my fork here: https://github.com/Axionize/portbase. Nevertheless, making this a compile-time variable is obviously not ideal and I've been stuck trying to figure out how to add a config setting for this.
It appears that I can pass the proxy string from some kind of data registry in portmaster to portbase but I'm struggling to figure out how to expose this setting to the end user as an option in the Advanced Menu in the Updates drop-down.
I was planning to bang my head against the wall looking at how portmaster, porbase, and portmaster-ui fit together until it worked but figured I should just ask. How do I expose a setting in the webui and pass that data from the ui -> portmaster -> portbase?
Also, what's the workflow supposed to look like for putting these components together then testing and debugging all of them?