Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle concurrency checkoutPaymentCreate and checkoutComplete #15991

Merged
merged 2 commits into from
May 16, 2024

Conversation

IKarbowiak
Copy link
Member

Port of #15956

Impact

  • New migrations
  • New/Updated API fields or mutations
  • Deprecated API fields or mutations
  • Removed API types, fields, or mutations

Docs

  • Link to documentation:

Pull Request Checklist

  • Privileged queries and mutations are either absent or guarded by proper permission checks
  • Database queries are optimized and the number of queries is constant
  • Database migrations are either absent or optimized for zero downtime
  • The changes are covered by test cases
  • All new fields/inputs/mutations have proper labels added (ADDED_IN_X, PREVIEW_FEATURE, etc.)
  • All migrations have proper dependencies
  • All indexes are added concurrently in migrations
  • All RunSql and RunPython migrations have revert option defined

Extend Checkout model with completing_started_at

Update completing_started_at checkout value in complete_checkout

Add validation in CheckoutPaymentCreate

Drop unused variable from _process_payment

Adjust _release_checkout_voucher_usage
@IKarbowiak IKarbowiak self-assigned this May 14, 2024
@db-queries
Copy link

db-queries bot commented May 14, 2024

Here is the report for bdccf6c (saleor:shopx-631-fix-payment-flow-3.17)
Missing base report (9ebf22b). The results couldn't be compared.

No differences were found.

@IKarbowiak IKarbowiak requested a review from a team May 14, 2024 12:02
@tomaszszymanski129 tomaszszymanski129 requested a review from a team May 15, 2024 09:00
@IKarbowiak IKarbowiak merged commit d82b6dc into 3.17 May 16, 2024
8 of 10 checks passed
@IKarbowiak IKarbowiak deleted the shopx-631-fix-payment-flow-3.17 branch May 16, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants