maven-surefire-plugin config add-opens (for JDK 17) #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix the Github Actions build, I'm not sure why this was excluded -- maybe there was a good reason?
Prepare for building with JDK 17.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
add-opensconfiguration option topom.xmlfor themaven-surefire-pluginto support building with JDK 17.There are issues with PowerMock in the
driver-vlcjmodule that must also be addressed to get a JDK 17 build working, but this fix does not affect the JDK 11 build.Note: This commit is based on PR #892 (to make it easy to verify that the JDK 11 build still works)