Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 5.4] replica/table.cc: Add metrics per-table-per-node #18683

Draft
wants to merge 1 commit into
base: branch-5.4
Choose a base branch
from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented May 15, 2024

Previous patches add per-table metrics reported per node (instead of per shard). Enabling table view for customers.
The per-node metrics reporting is on by default; this is why the number of metrics is limited.

This patch adds metrics that will be reported per table, per node. The added metrics (that are part of the per-table per-shard metrics) are:
scylla_column_family_cache_hit_rate
scylla_column_family_read_latency
scylla_column_family_write_latency
scylla_column_family_live_disk_space

And they are used by the keyspace/table dashboard.
Fixes #18642
image

No need to backport, it's part of 6.0

(cherry picked from commit bc3cc67)

Refs #18645

This patch adds metrics that will be reported per-table per-node.
The added metrics (that are part of the per-table per-shard metrics)
are:
scylla_column_family_cache_hit_rate
scylla_column_family_read_latency
scylla_column_family_write_latency
scylla_column_family_live_disk_space

Fixes #18642

Signed-off-by: Amnon Heiman <amnon@scylladb.com>
(cherry picked from commit bc3cc67)

# Conflicts:
#	replica/table.cc
@mergify mergify bot added the conflicts label May 15, 2024
@mergify mergify bot assigned amnonh May 15, 2024
Copy link
Author

mergify bot commented May 15, 2024

Cherry-pick of bc3cc67 has failed:

On branch mergify/copy/branch-5.4/pr-18645
Your branch is up to date with 'origin/branch-5.4'.

You are currently cherry-picking commit bc3cc6777b.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   replica/table.cc

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot marked this pull request as draft May 15, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant