Batch and pipeline multiple Redis calls together #4508
Draft
+171
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Woellchen
force-pushed
the
improve_redis_performance
branch
from
452a61c
to
5ee984b
Compare
|
As a Redis v7 user with SeaweedFS configured to use |
chrislusf
reviewed
May 31, 2023
|
|
||
| // Clean expired keys | ||
| var expiredEntries []*filer.Entry | ||
| for _, entry := range entries { |
There was a problem hiding this comment.
what if the entries in the first batch are all expired?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem are we solving?
When using Redis store there are a lot of single commands sent to Redis sequentially. This causes many round trips and network IO wait.
For example for directories this produces a GET command for each child in the directory. Imagine a folder with a million files, it would sequentially execute 1 million GET commands.
How are we solving the problem?
Using the client-side pipelining feature to send all commands and get all their results in a single roundtrip.
This is implemented for
redis2stores. If you like the idea I can go ahead and change the other redis stores as well.How is the PR tested?
Checks