Update superblock when changing replication #4975
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrislusf
reviewed
Nov 2, 2023
| @@ -557,6 +559,25 @@ func (s *Store) ConfigureVolume(i needle.VolumeId, replication string) error { | |||
| if err != nil { | |||
| return fmt.Errorf("volume %d failed to save vif: %v", i, err) | |||
| } | |||
| // update superblock | |||
There was a problem hiding this comment.
please refactor this to a function, and just print a warning instead of failing in the middle.
There was a problem hiding this comment.
Ok, refactoring this into a function makes sense.
But I don't see why printing a warning here makes sense. If a problem occurs while loading or saving the ".vif", it fails with an error, so updating the superblock should be done the same way?
There was a problem hiding this comment.
there should be only one source of truth, which is the .vif file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem are we solving?
.vif file and superblock are not in sync, see issue #4944
With this PR, the superblock gets updated when the replication is changed using
weed shellIt is basically the code from
seaweedfs/unmaintained/change_superblock/change_superblock.goI'm not sure if ConfigureVolume() is the best place to do this or if VolumeConfigure() in
volume_grpc_admin.goif better.So feel free to make changes :)