consul filer store #5042
Draft
consul filer store #5042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unRob
force-pushed
the
feature/consul-filer
branch
from
db0d839
to
f607f97
Compare
unRob
force-pushed
the
feature/consul-filer
branch
from
f607f97
to
70d8c40
Compare
unRob
force-pushed
the
feature/consul-filer
branch
from
70d8c40
to
79c8526
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem are we solving?
I run Hashicorp Consul at home and would like to use it as the kv store for filer. I'm new to the project and will be running my fork to try it out for the first time. My end goal is to use seaweed through the CSI driver on my nomad cluster as a simple way to provide persistent storage.
How are we solving the problem?
Copied the flow of the etcd store (thanks, previous contributors!) and used consul's official golang sdk to implement the
filer.FilerStoreinterface.How is the PR tested?
Based test on existing etcd test, enabled it and made sure it ran against a dockerized Consul in dev mode. Also ran
make test_consul, again, trying to emulate the existing etcd implementation but not sure how to measure success here, as apparently I missed a step where a bucket is created for the registry.As said above, will be running a fork at home to fully test out the implementation (as well as getting to know the project). Will mark as ready for review once I review it running for a while.
Checks