Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor ifs #5540

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

refactor ifs #5540

wants to merge 2 commits into from

Conversation

kmlebedev
Copy link
Contributor

What problem are we solving?

small refactor #5539

  • if to switch
  • string metrod to const

How are we solving the problem?

improve readability

How is the PR tested?

Checks

  • I have added unit tests if possible.
  • I will add related wiki document changes and link to this PR after merging.

@chrislusf
Copy link
Collaborator

Go test failed.

@KevinBLT
Copy link
Contributor

@kmlebedev

I would assume test fails because at least curl for example sends Content-Type: multipart/form-data; boundary="----xyz", so I think it's not possible to simply test with equality operator here.

Additionally, I am not sure if the content-type is always set to multipart/form-data by existing clients, so if it's empty I think it should be treated as multipart/form-data for backwards compatibility. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants