Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove default props from image component #177

Merged
merged 1 commit into from
May 20, 2024

Conversation

bang9
Copy link
Collaborator

@bang9 bang9 commented May 14, 2024

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team developer-advocates@sendbird.com with details
and we'll evaluate if we can setup a CLA to allow for the contribution.

For Internal Contributors

[TICKET_ID]

Description Of Changes

Removed defaultProps assignment
image

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)
  • Test

@bang9 bang9 self-assigned this May 14, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 13.01%. Comparing base (9f8e4b0) to head (b7ed0e7).

Files Patch % Lines
...oundation/src/components/Image/Image.fastimage.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #177   +/-   ##
=======================================
  Coverage   13.01%   13.01%           
=======================================
  Files         334      334           
  Lines        7432     7432           
  Branches     2051     2052    +1     
=======================================
  Hits          967      967           
  Misses       6392     6392           
  Partials       73       73           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bang9 bang9 requested a review from OnestarLee May 20, 2024 02:37
Copy link
Collaborator

@OnestarLee OnestarLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@bang9 bang9 merged commit d0df9dd into main May 20, 2024
6 checks passed
@bang9 bang9 deleted the chore/remove-default-props branch May 20, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants