Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable the 'conversions' feature #2938

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

enable the 'conversions' feature #2938

wants to merge 2 commits into from

Conversation

bin-ly
Copy link

@bin-ly bin-ly commented Apr 15, 2024

use of deprecated associated function os_str_bytes::RawOsString::assert_from_raw_vec

Enselic
Enselic reviewed May 27, 2024
View reviewed changes
Copy link
Collaborator

@Enselic Enselic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to make a contribution.

I'm not quite following what you are doing here. In what way is bat better after this change than it was before? For example from the perspective of a user, or from the perspective of a developer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enselic Enselic Enselic left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bin-ly @Enselic