Add CODEOWNERS #2117
Merged
Add CODEOWNERS #2117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppfeister
force-pushed
the
feature/codeowners
branch
from
5f86ced
to
253e4d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're beginning to put together proper packaging for Sherlock.
@sdushantha is packaging for
{insert discussed repo}. Changes to the pyproject or setup.cfg files can screw with builds. As the person maintaining that package, it'd be worth having their sign off.While he works on that deployment, I'm in the process of packaging for
{insert an official repo}. My packaging, even if I don't end up downstream of his ^ package, will still rely on those two files. Changes to them without knowing could impact those workflows and builds.How do we feel about enforcing code owner approvals on master for these situations? Note that only one code owner approval is ever necessary for protected files, not everyone all at once.
Less about "don't touch!" more about making sure people can validate against pipelines and that builds work and such before anything breaks. CodeOwners should auto-ping whoever is tagged when an owned-file is pr-ed against.