-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/Integration: Add FileTest #819
base: master
Are you sure you want to change the base?
Conversation
@Art4 Do you think something like this is reasonable? I tried finding a library for the PHP server but after reviewing the following, I gave up and wrote my own helper class:
|
I would have said that it is not worth the effort to create such a test because the File class will be deprecated. But since you've already done the work, we can keep the test. Requiring a separate library for it would definitely be too much. |
3cf2b9f
to
bdb50df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review, updated. I think this integration test will be useful for PSR-18 as well since how the permanent/temporary redirection interact with get_final_url
is non-trivial. Though there we at least will not need to spawn a server since that will support mocking.
Since the custom HTTP client in File based on curl cannot really be mocked, let’s add an actual HTTP server to allow for integration and regression testing during the transition to PSR-18 implementations.
This is a regression test for simplepie#812.
This is a regression test for #812.