[BUG] fix classifier default _predict returning integer labels always, even if fit y was not integer
#6430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
module:classification
fkiraly
requested review from
achieveordie,
benHeid and
yarnabrina
as code owners
This was referenced May 15, 2024
fkiraly
added a commit
that referenced
this pull request
May 22, 2024
…ing `y` of different type in `predict` (#6432) Towards #6431. Fixes `ProximityForest`, tree, stump, and `IndividualBOSS` returning `y` of different type in `predict`. The `IndividualBOSS` was coercing to `object` which was turned of. The proximity classifiers had `_predict` being copy-paste of the default `_predict` which was fixed in #6430. The fix is deduplication, so the `_predict` defaults to the fixed parent classes' predict. Tested via #6428
fkiraly
added a commit
that referenced
this pull request
May 22, 2024
…e type and labels (#6428) This PR extends the suite test `test_classifier_on_unit_test_data` to test that `y` of object or str dtype `y` leads to correct labels on `predict` outputs. Covers second bug in #6427, namely the example returning integer labels instead of string labels - but does not fix the bug. It is hence expected that the test will detect bug #6427. Depends on the following PR which fix newly covered bugs: * #6430 * #6432
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes one of the bugs reported in #6427, namely the default
_predictinBaseClassifieralways returning integer labels, even if the original labels were not integers.This would cause all classifiers that did not have a custom
_predictimplemented - a few composites, among themBaggingClassifier- to always predict integers, even if theyseen infitwas of another type.The fix is simple, adding a missing application of the memorized integer-to-class dictionary.
Test coverage is through #6428.