Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Interval width (sharpness) metric #6437

Merged
merged 4 commits into from
May 21, 2024
Merged

[ENH] Interval width (sharpness) metric #6437

merged 4 commits into from
May 21, 2024

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented May 17, 2024

Interval width metric for interval forecasts, as requeste by @benHeid.

@fkiraly fkiraly added enhancement Adding new functionality module:metrics&benchmarking metrics and benchmarking modules labels May 17, 2024
@@ -599,6 +599,70 @@ def get_test_params(self):
return [params1]


class IntervalWidth(_BaseProbaForecastingErrorMetric):
"""Interval width for interval predictions, sometimes also known as calibration.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean calibration or sharpness?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure - which one is correct?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After taking again a look into Gneiting et. al. "Probabilistic forecasts, calibration and sharpness" [1]. I would say that this is sharpness.

[1] https://sites.stat.washington.edu/raftery/Research/PDF/Gneiting2007jrssb.pdf

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamed

@fkiraly fkiraly changed the title [ENH] Interval width (calibration) metric [ENH] Interval width (sharpness) metric May 19, 2024
benHeid
benHeid previously approved these changes May 20, 2024
Copy link
Contributor

@benHeid benHeid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment on the naming of a variable. Not sure, if my suggestion is better. Thus, the comment is not blocking.

@fkiraly fkiraly merged commit 791d3cb into main May 21, 2024
53 checks passed
@fkiraly fkiraly deleted the interval-calibration branch May 21, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding new functionality module:metrics&benchmarking metrics and benchmarking modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants