-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Null Promotion Configuration in core #5744
Draft
mamhoff
wants to merge
13
commits into
solidusio:main
Choose a base branch
from
mamhoff:use-null-promo-config
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_core
Changes to the solidus_core gem
label
May 7, 2024
mamhoff
force-pushed
the
use-null-promo-config
branch
from
May 16, 2024 12:59
09b93ba
to
82c98ae
Compare
github-actions
bot
added
the
changelog:repository
Changes to the repository not within any gem
label
May 16, 2024
mamhoff
force-pushed
the
use-null-promo-config
branch
from
May 17, 2024 08:32
82c98ae
to
636e27b
Compare
github-actions
bot
added
the
changelog:solidus_api
Changes to the solidus_api gem
label
May 17, 2024
mamhoff
force-pushed
the
use-null-promo-config
branch
from
May 28, 2024 08:48
636e27b
to
a0c8ca0
Compare
The previous implementation of `Spree::DeprecatedConfigurableClass` could deal with instance methods, but not with class methods. This creates a thing that issues deprecation warnings on instance methods and class methods.
jarednorman
reviewed
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I absolutely love the direction you're taking this.
mamhoff
force-pushed
the
use-null-promo-config
branch
from
May 29, 2024 12:24
a0c8ca0
to
25edb75
Compare
This changes the order spec in core to rely on the stubbed null promotion system. The specs for the legacy promotion system have been moved to the legacy_promotions gem.
The existing promotion handlers are activated using either `#apply` or `#activate`. The return value `#activate` is usually not read, and is thus not really important, but that of `#apply` must be the handler itself, so that e.g. the adjustments admin has access to any application errors.
The one example here relies on the legacy promo system.
This one spec should not live here.
We still carry models and specs that are part of the legacy promotion system in core. In this PR, I do not want to move these over, as that comes with changes to migrations. Instead, this changes the configuration just for the affected specs to keep the test suite green.
We want to use the legacy `Spree::PromotionConfiguration` in the solidus_legacy_promotions test suite.
mamhoff
force-pushed
the
use-null-promo-config
branch
from
May 29, 2024 13:33
25edb75
to
bb52430
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog:repository
Changes to the repository not within any gem
changelog:solidus_api
Changes to the solidus_api gem
changelog:solidus_core
Changes to the solidus_core gem
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We want to use the legacy
Spree::PromotionConfiguration
in the solidus_legacy_promotions test suite.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: