Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Ruby 3.3 for Windows CI #3393

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Conversation

Artalus
Copy link

@Artalus Artalus commented Apr 10, 2024

Ruby 3.2 has issues with non-English entries in Registry.

Relates to #3371 and probably other crash reports mentioning Error reading ports via Boot Daemon STDOUT.

UPD: Was going to simply check if the project even builds with 3.3, but GHA says This workflow is awaiting approval from a maintainer 馃槥

3.2 has issues with non-English entries in Registry.
@ethancrawford
Copy link
Collaborator

Have kicked it off. Fingers crossed 馃槃

@Artalus
Copy link
Author

Artalus commented Apr 11, 2024

Linux and Mac failed while building libsndfile, which is probably an unrelated error somewhere in vcpkg ports. I don't have much experience with it sadly, aside from it never working the way I wanted 馃槄

Windows built successfully but failed at ctest with

Error: An error occurred trying to start process 'C:\Windows\system32\cmd.EXE' with working directory 'D:\a\sonic-pi\sonic-pi/app/build/api-tests'. The directory name is invalid

which is cryptic as well - both the last commit changing the workflow aa63dc7 and the last commit built before mine fa6e49f were built successfully... This might be just a random CI quirk requiring a simple re-run, but I kinda doubt it.

@samaaron
Copy link
Collaborator

I just updated vcpkg to the latest release and it still seems to be failing as described above. Not sure what's going on here at all.

I did manage to build things successfully with Qt 6.7 on my Apple Silicon Mac - so it's possible it might be an issue with vcpkg and the CI?

If anyone can help I'd love to hear your thoughts....

Oh, and updating Ruby to 3.3 in the CI only affects the tests. Release builds are currently manually built - and Sonic Pi is designed to support Ruby back to v2.x

@samaaron
Copy link
Collaborator

Possibly related: microsoft/vcpkg#38112 (comment)

@Artalus
Copy link
Author

Artalus commented Apr 11, 2024

If anyone can help I'd love to hear your thoughts....

I might take a look at it at some point in a fork, but I am knee-deep in other random stuff nowadays, so I cannot promise anything 馃槄

Oh, and updating Ruby to 3.3 in the CI only affects the tests. Release builds are currently manually built

Yup, figured that much since the only upload in the workflow is related to logs 馃檭 . Wanted simply to check preemptively that the upgrade wouldn't break the build at the very least.

@samaaron
Copy link
Collaborator

For the record, today I built the latest Sonic Pi with Ruby 3.3 and Qt 6.7 on my Windows machine and it seems to be working just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants