Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translations for Menu and Menu Items #11827

Draft
wants to merge 102 commits into
base: feature/mobility_gem
Choose a base branch
from
Draft

Translations for Menu and Menu Items #11827

wants to merge 102 commits into from

Conversation

rafalkosla101
Copy link
Contributor

@rafalkosla101 rafalkosla101 commented Jan 9, 2023 •
edited by nciemniak

Menu and Menu Item translations via Mobility.

Remaining to do:

  • change data transfer migrations to account for existing locale values set in Menu resources.

MatthewKennedy and others added 30 commits November 9, 2022 21:25
@MatthewKennedy
Make schemas publicly visible for better documentation.
fd7d14e
@MatthewKennedy
Fix extension generation.
c947897
@rafalcymerys
Bump version to 4.5.0
96ee351
@wjwitek
change functino getting locale to first look at locale saved in user …
609ca1e 
…if there is one
@wjwitek
add saved_locale to platform's user endpoint
ef8cc8e
@wjwitek
add saved_locale to storefront's account endpoint
0f660fb
@wjwitek
change permitted user attributes
f377965
@wjwitek
add migration and change saved_locale to selected_locale
5d5ba24
@lkol
Make sure to use Metadata module from Spree namespace to prevent conf…
26f9f3f 
…licts
@wjwitek
change using user locale to be configurable
ffab5fc
@rafalcymerys
Bump version to 4.6.0.alpha
25f0e4e
@wjwitek
add tests
cec549d
@wjwitek
reduce complexity
eaef3b3
@wjwitek
fix a mistake
3ccf1a8
@wjwitek
move long conditions to functions
9a29bb4
@wjwitek
fix test by mocking a method
fb9964b
@wjwitek
change migration file to work for other user types
521d54c
@wjwitek
remove unnecessary selected_locale
3194686
@nciemniak
revert taxonomy translation
3ca1c41
@wjwitek
allow controller to reveive spree_current_user more than once
69752d1
@wjwitek
change migration to be compatible with rails 6.1
ea13d81
@nciemniak
delete taxonomy translation migration files
c391f69
@nciemniak
update methods checking for changes in translated values
0eb3495
@wjwitek @rafalcymerys
Update api/spec/serializers/spree/api/v2/platform/user_serializer_spe…
02f1ef9 
…c.rb

Co-authored-by: Rafał Cymerys <rafal@upsidelab.io>
@wjwitek
add description to test
737c716
@wjwitek
udate api docs with selected_locale
0941a33
@nciemniak
use mobility dirty plugin instead of manual checks for saved changes
4359548
@rafalcymerys
Merge pull request #11814 from wjwitek/locale_in_user
768a80c 
Locale in user
@nciemniak
account for mysql rules for select statements
bade87b
@nciemniak
add brakeman warning to ignore list
5cc7847
nciemniak and others added 25 commits January 18, 2023 15:49
@nciemniak
menu translations
05dcff8
@nciemniak
fix broken menu tests
895d415
@nciemniak
account for issue with Rails if_exists on dropping indexes
3f66724
@nciemniak @adrianryt @rafalkosla101
Add translations for Option Type, Option Value, Property, & Product P…
ec416ae 
…roperty (#11831)

Co-authored-by: aryt <adrianryt3@gmail.com>
Co-authored-by: adrianryt <adrianryt3@gmal.com>
Co-authored-by: Rafal Kosla <rafalkosla101@gmail.com>
@wjwitek
add keyserver and apt-get update
9ce0010
@rafalcymerys
Merge pull request #11843 from spree/fix/circleci_install_libvips
97d01a5 
add sudo apt-get update before install libvips
@wjwitek
First working version of feed generation.
db6424b
@wjwitek
Refactor service, model and controller.
519ace4
@wjwitek
Tests for DataFeed model and feed generation service.
c3a1133
@wjwitek
Refactor services to be clearer.
a26e569
@wjwitek
Add sample data for DataFeed
74043ce
@wjwitek
add basic api for google feed settings
f59adcd
@wjwitek
Split DataFeed generation into multiple services.
1027a07
@wjwitek
move data feeds api to seperate controller
14d4161
@wjwitek
Add functionalities for admin dashboard: nested attributes for store,…
d82fcff 
… name and provider columns.
@rafalcymerys
Merge pull request #11825 from wjwitek/export_products_to_rss
707dbba 
Export products to rss
@rafalcymerys
Remove unnecessary build configurations
930e3b4
@nciemniak
taxonomies: rewrite first_or_create for mobility compatibility
ed30ad6
@nciemniak
menus: rewrite first_or_create for mobility compatibility
e5b9c35
@rafalcymerys
Merge pull request #11844 from spree/chore/remove-unnecessary-build-c…
a6972ad 
…onfigurations

Remove unnecessary build configurations
@wjwitek
change port 3000 to 4000 in api docs and store sample (#11846)
81525b4
@nciemniak
add menu item translations
8bec027
@nciemniak
Merge branch 'main' into feature/menu_and_cms_translations
b46d570 
# Conflicts:
#	core/brakeman.ignore
#	core/db/migrate/20230103144439_create_option_type_translations.rb
#	core/db/migrate/20230103151034_create_option_value_translations.rb
#	core/db/migrate/20230109084253_create_product_property_translations.rb
#	core/db/migrate/20230109105943_create_property_translations.rb
@nciemniak
fix tests and cleanup
077540e
@nciemniak
make translations accessible for deleted products
fa8ced8
@rafalcymerys
Copy link
Member

We decided not to merge it right now, since adding content translations to 4.6 is a big change already. Menu and CmsPage entities are already translatable, just not via mobility.

I think we should get back to that in further versions and unify the structure then.

@nciemniak nciemniak changed the title WIP Add menus to translatable resources Translations for Menu and Menu Items Feb 10, 2023
@nciemniak nciemniak mentioned this pull request Feb 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nciemniak nciemniak Awaiting requested review from nciemniak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rafalkosla101 @rafalcymerys @MatthewKennedy @wjwitek @lkol @nciemniak