Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new welcome page #11849

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add new welcome page #11849

wants to merge 2 commits into from

Conversation

wjwitek
Copy link
Contributor

@wjwitek wjwitek commented Feb 13, 2023

Assets, controller and view for new welcome page that will be shown when someone goes to localhost:4000 with no frontend installed.

@viezly
Copy link

viezly bot commented Feb 13, 2023

This pull request is split into 5 parts for easier review.
👀 Review pull request on Viezly

Changed files are located in these folders:

  • /
  • core
  • core/app
  • core/config

Copy link
Contributor

@nciemniak nciemniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great to me besides the one note on the welcome page variables. Nice work 🎉

@wjwitek wjwitek marked this pull request as ready for review March 6, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants