Improve line item packaging #11932
Open
Improve line item packaging #11932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an order has two line_items that have the same variant_id (for example when using line_item_comparison_hooks), they were effectively getting merged and added into a package as one inventory_unit. Grouping by line_item_id fixes that.
The @adjuster[hash_item item] would cause the adjuster to discard additional package content items that reference the same variant_id as a content item that has already been iterated over, but which should be processed separately from each other (for example when using line_item_comparison_hooks).
|
Changes preview: Legend: |
|
Hi @Tashows thank you for submitting this. Let me review in more detail and get back to you, at first sight it seems to make sense. |
|
@rafalcymerys I do plan on following up with a more complete PR on this, because I am working on it anyway for another project (things break in the admin interface as well), but things have come up. Will update once I get the chance to finish this. |
|
@Tashows that sounds great, anytime you have the updated PR just ping me and I'll take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8621
More context is provided in the original issue and in each commit body.