open SimpleJobLauncher for extension #3637
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmbenhassine
added
the
status: waiting-for-triage
hosuaby
force-pushed
the
feature/extendableSimpleJobLauncher
branch
from
eeb24eb
to
18195fa
Compare
fmbenhassine
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONTEXT: In my project I was needed a custom
JobLauncherimplementation that delays execution of the job until some condition become true. In order to achieve it, I copied all code fromSimpleJobLauncher. This work could be done more easily ifSimpleJobLauncherwas open for extension.In this PR, I added two protected methods
createJobExecutionandlaunchJobExecutionto classSimpleJobLauncher. Creation ofJobExecutionis now decoupled from its execution.