Add delete cascade on metadata tables' foreign keys #4584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mayleaf Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@mayleaf Thank you for signing the Contributor License Agreement! |
mayleaf
commented
May 5, 2024
| @@ -135,8 +135,17 @@ public void removeJobExecutions(Collection<JobExecution> jobExecutions) { | |||
| for (JobExecution jobExecution : jobExecutions) { | |||
There was a problem hiding this comment.
Can I delete this method since it's no longer used after this pull request?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved #4555
On DELETE CASCADE on Foreign Keys #4555, We found delete methods in SimpleJobRepository are removing with separated SQL queries for each metadata tables
Add ON DELETE CASCADE to each metadata tables' foreign keys.