Polishing in Asciidoctor rendering #608
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odrotbohm
requested changes
May 20, 2024
| @@ -208,16 +208,14 @@ public String renderConfigurationProperties(ApplicationModule module, List<Modul | |||
|
|
|||
| var defaultValue = it.defaultValue(); | |||
|
|
|||
| if (defaultValue != null && StringUtils.hasText(defaultValue)) { | |||
There was a problem hiding this comment.
I've kept the additional, explicit checks, as only those cause the null analysis in Eclipse to realize that defaultValue is not null. Simply passing it to StringUtil.hasText(…) doesn't do the trick and the compiler would now mark the invocation of toInlineCode(…) as problematic as the method expects a non-null value.
odrotbohm
pushed a commit
that referenced
this pull request
May 22, 2024
|
That's merged, thanks! |
odrotbohm
added
in: reference documentation
This was referenced May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StringUtils.hasTextalready includes non null check so the additional check is not needed.Parsing the module in
renderConfigurationPropertiesisn't needed anymore because theModulePropertylist is already module specific.