Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show parsed bridge messages #20058

Merged
merged 1 commit into from
May 27, 2024
Merged

Show parsed bridge messages #20058

merged 1 commit into from
May 27, 2024

Conversation

Parveshdhull
Copy link
Member

@Parveshdhull Parveshdhull commented May 16, 2024 •
edited

fixes #19977
fixes #19976

status-go PR: status-im/status-go#5192

Testing Note:

Only newly fetched messages will be parsed.

status: ready

@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA May 16, 2024
@Parveshdhull Parveshdhull self-assigned this May 16, 2024
@status-im-auto
Copy link
Member

status-im-auto commented May 16, 2024 •
edited

Jenkins Builds

Click to see older builds (47)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 8a60e69 #1 2024-05-16 09:26:37 ~2 min tests 📄log
✔️ 8a60e69 #1 2024-05-16 09:32:14 ~8 min android-e2e 🤖apk 📲
✔️ 8a60e69 #1 2024-05-16 09:32:16 ~8 min android 🤖apk 📲
✔️ 8a60e69 #1 2024-05-16 09:34:03 ~10 min ios 📱ipa 📲
❌ dcbbec1 #2 2024-05-16 11:22:22 ~2 min tests 📄log
✔️ dcbbec1 #2 2024-05-16 11:27:19 ~7 min android-e2e 🤖apk 📲
✔️ dcbbec1 #2 2024-05-16 11:27:26 ~7 min android 🤖apk 📲
✔️ dcbbec1 #2 2024-05-16 11:34:45 ~14 min ios 📱ipa 📲
✔️ 0e20aaa #3 2024-05-16 13:03:54 ~3 min tests 📄log
✔️ 0e20aaa #3 2024-05-16 13:06:59 ~7 min android-e2e 🤖apk 📲
✔️ 0e20aaa #3 2024-05-16 13:07:01 ~7 min android 🤖apk 📲
✔️ 0e20aaa #3 2024-05-16 13:09:57 ~9 min ios 📱ipa 📲
✔️ dcb5f7e #5 2024-05-20 13:16:28 ~5 min tests 📄log
✔️ dcb5f7e #5 2024-05-20 13:19:24 ~7 min android 🤖apk 📲
✔️ dcb5f7e #5 2024-05-20 13:21:30 ~10 min android-e2e 🤖apk 📲
✔️ dcb5f7e #5 2024-05-20 13:22:29 ~11 min ios 📱ipa 📲
✔️ f57eabe #6 2024-05-20 14:23:29 ~5 min tests 📄log
✔️ f57eabe #6 2024-05-20 14:26:25 ~8 min android-e2e 🤖apk 📲
✔️ f57eabe #6 2024-05-20 14:27:24 ~9 min android 🤖apk 📲
✔️ f57eabe #6 2024-05-20 14:28:40 ~10 min ios 📱ipa 📲
❌ ee9d3d8 #7 2024-05-20 14:35:45 ~3 min tests 📄log
✔️ ee9d3d8 #7 2024-05-20 14:39:51 ~8 min android-e2e 🤖apk 📲
✔️ ee9d3d8 #7 2024-05-20 14:39:51 ~8 min android 🤖apk 📲
✔️ 36d06ef #8 2024-05-20 14:45:22 ~3 min tests 📄log
✔️ 36d06ef #8 2024-05-20 14:48:16 ~6 min android-e2e 🤖apk 📲
✔️ 36d06ef #8 2024-05-20 14:48:53 ~7 min android 🤖apk 📲
✔️ 36d06ef #8 2024-05-20 14:51:05 ~9 min ios 📱ipa 📲
✔️ d66ce89 #9 2024-05-21 09:29:39 ~4 min tests 📄log
✔️ d66ce89 #9 2024-05-21 09:33:36 ~8 min android-e2e 🤖apk 📲
✔️ d66ce89 #9 2024-05-21 09:33:40 ~8 min android 🤖apk 📲
✔️ d66ce89 #9 2024-05-21 09:34:46 ~9 min ios 📱ipa 📲
❌ 108b920 #10 2024-05-22 12:04:31 ~4 min tests 📄log
✔️ 108b920 #10 2024-05-22 12:09:22 ~8 min android-e2e 🤖apk 📲
✔️ 108b920 #10 2024-05-22 12:10:39 ~10 min android 🤖apk 📲
✔️ 108b920 #10 2024-05-22 12:11:42 ~11 min ios 📱ipa 📲
✔️ 4f8e837 #11 2024-05-22 12:30:54 ~6 min tests 📄log
✔️ 4f8e837 #11 2024-05-22 12:31:07 ~7 min android 🤖apk 📲
✔️ 4f8e837 #11 2024-05-22 12:31:14 ~7 min android-e2e 🤖apk 📲
✔️ 4f8e837 #11 2024-05-22 12:33:32 ~9 min ios 📱ipa 📲
✔️ d27f315 #12 2024-05-23 14:40:48 ~4 min tests 📄log
✔️ d27f315 #12 2024-05-23 14:43:53 ~7 min android-e2e 🤖apk 📲
✔️ d27f315 #12 2024-05-23 14:45:27 ~8 min android 🤖apk 📲
✔️ d27f315 #12 2024-05-23 14:46:20 ~9 min ios 📱ipa 📲
✔️ 7a5b8f5 #13 2024-05-24 14:16:44 ~4 min tests 📄log
✔️ 7a5b8f5 #13 2024-05-24 14:19:33 ~7 min android-e2e 🤖apk 📲
✔️ 7a5b8f5 #13 2024-05-24 14:19:35 ~7 min android 🤖apk 📲
✔️ 7a5b8f5 #13 2024-05-24 14:24:08 ~11 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 5a47eb3 #14 2024-05-27 08:50:29 ~5 min tests 📄log
✔️ 5a47eb3 #14 2024-05-27 08:53:58 ~9 min android-e2e 🤖apk 📲
✔️ 5a47eb3 #14 2024-05-27 08:54:57 ~9 min android 🤖apk 📲
✔️ 5a47eb3 #14 2024-05-27 08:56:14 ~11 min ios 📱ipa 📲
✔️ 5a47eb3 #15 2024-05-27 09:05:08 ~4 min tests 📄log
✔️ ecfe449 #16 2024-05-27 10:03:21 ~4 min tests 📄log
✔️ ecfe449 #15 2024-05-27 10:07:14 ~8 min android-e2e 🤖apk 📲
✔️ ecfe449 #15 2024-05-27 10:07:20 ~8 min android 🤖apk 📲
✔️ ecfe449 #15 2024-05-27 10:08:48 ~9 min ios 📱ipa 📲

@Parveshdhull Parveshdhull force-pushed the fix/bridge-messages branch 2 times, most recently from dcbbec1 to 0e20aaa Compare May 16, 2024 12:59
@Parveshdhull Parveshdhull mentioned this pull request May 20, 2024
Merged
@Parveshdhull Parveshdhull changed the title [WIP]: Improve bridge messages representation Show parsed bridge messages May 20, 2024
@Parveshdhull Parveshdhull marked this pull request as ready for review May 20, 2024 13:10
@Parveshdhull Parveshdhull force-pushed the fix/bridge-messages branch 4 times, most recently from 36d06ef to d66ce89 Compare May 21, 2024 09:24
@Parveshdhull Parveshdhull requested a review from jo-mut May 21, 2024 09:26
flexsurfer
flexsurfer reviewed May 21, 2024
View reviewed changes
Copy link
Member

@flexsurfer flexsurfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @Parveshdhull thank you for the PR, could we please keep it as a separate component and do not mix with our message components

@Parveshdhull
Copy link
Member Author

Parveshdhull commented May 21, 2024 •
edited

hi @flexsurfer thank you for reviewing PR.

hey @Parveshdhull thank you for the PR, could we please keep it as a separate component and do not mix with our message components

Having separate components do looks neater, but it lacks functionality. We are already duplicating author/message container styles for bridge message, if we are to support press/long-press etc. we have to duplicate this to and more.

status-mobile/src/status_im/contexts/chat/messenger/messages/content/view.cljs

Line 176 in 34cf65b

context (assoc context

Please can you elaborate what will the benefit of having it as separate and what are drawbacks of current approach.

@flexsurfer
Copy link
Member

hi @flexsurfer thank you for reviewing PR.

hey @Parveshdhull thank you for the PR, could we please keep it as a separate component and do not mix with our message components

Having separate components do looks neater, but it lacks functionality. We are already duplicating author/message container styles for bridge message, if we are to support press/long-press etc. we have to duplicate this to and more.

status-mobile/src/status_im/contexts/chat/messenger/messages/content/view.cljs

Line 176 in 34cf65b

context (assoc context

Please can you elaborate what will the benefit of having it as separate and what are drawbacks of current approach.

thank you @Parveshdhull , it should be separate, it's not duplicating, it's just the same implementation, but it's fine that it's still separate, because it's not a regular status message, and it shouldn't behave like status message, so we should keep separate implementation for it, there should be no interactions (like press/long press) etc , adding conditions like (when-not bridge-name added?) to our components not good as well

@Parveshdhull
Copy link
Member Author

there should be no interactions (like press/long press) etc

@pavloburykh Please can you confirm? Because according to issue #19977,

  1. Long tap bridged message in Status app

Actual result: message is not tappable, bottom sheet does not appear.

PS: I can revert these changes in PR and only address parsing of bridge message if that's what we want. But If we want to support reactions etc. on bridged message then I think they are working in PR.

@pavloburykh
Copy link
Contributor

Hey @Parveshdhull! Thank you for this PR.

@pavloburykh Please can you confirm?

That's a good point. Let me compare the behaviour on Desktop and I will come back with an answer after that.

@pavloburykh pavloburykh self-assigned this May 22, 2024
@pavloburykh
Copy link
Contributor

pavloburykh commented May 22, 2024 •
edited

there should be no interactions (like press/long press) etc

@pavloburykh Please can you confirm? Because according to issue #19977,

  1. Long tap bridged message in Status app

Actual result: message is not tappable, bottom sheet does not appear.

PS: I can revert these changes in PR and only address parsing of bridge message if that's what we want. But If we want to support reactions etc. on bridged message then I think they are working in PR.

So, I have compared with Desktop app and here what I see.

On Desktop user can perform following interactions with Bridged for Discord messages:

  1. Set a reaction
  2. Send reply
  3. Pin
  4. Mark as unread (I believe we do not have such feature on mobile, so this is Desktop only)
Status Desktop 2024-05-22 13-51-29

On mobile in PR build longtap menu options are slightly different:

  1. Set a reaction
  2. Send reply
  3. Copy text
  4. Delete for me
  5. Delete for everyone

photo_2024-05-22 14 09 08

Summary:

Based on the above comparison I believe we should show the following options for bridged messages on mobile:

  1. Set a reaction
  2. Send reply
  3. Copy text (Desktop does not show it but I think it is okay to leave this option on mobile)
  4. Pin message (if available)
  5. Delete for me

We should not show:

Delete for everyone
Mark as unread - as we do not have such feature on mobile, we can ignore it.

@Parveshdhull
Copy link
Member Author

thank you very much @pavloburykh for checking. Will update the PR as per summary

@Parveshdhull Parveshdhull force-pushed the fix/bridge-messages branch 2 times, most recently from 108b920 to 4f8e837 Compare May 22, 2024 12:23
@pavloburykh
Copy link
Contributor

pavloburykh commented May 22, 2024 •
edited

thank you very much @pavloburykh for checking. Will update the PR as per summary

thank you! I have updated summary and added 'Delete for me` based on our conversation in Discord.

@Parveshdhull
Copy link
Member Author

it's not a regular status message, and it shouldn't behave like status message

@flexsurfer, as we have confirmed that bridge messages should behave somewhat like regular messages, please can we go ahead with PR?
We can further explore more about simplification of these components later.

@Parveshdhull
Copy link
Member Author

Thank you @churik for finding this bug, should be fixed now.

@churik churik moved this from IN TESTING to E2E Tests in Pipeline for QA May 24, 2024
@churik
Copy link
Member

churik commented May 24, 2024

No more issues from my side, thank you for your amazing work!!!
I'll wait for the final e2e results and send PR to merge.

@churik churik moved this from E2E Tests to IN TESTING in Pipeline for QA May 24, 2024
@status-im-auto
Copy link
Member

88% of end-end tests have passed

Total executed tests: 52
Failed tests: 3
Expected to fail tests: 3
Passed tests: 46

IDs of failed tests: 727230,727229,727232 

IDs of expected to fail tests: 703495,703503,702807

Failed tests (3)

Click to expand
  • Rerun failed tests

    • Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230 
    critical/test_wallet.py:119: in test_wallet_send_asset_from_drawer
    self.wallet_view.navigate_back_to_wallet_view()
 'TestWalletMultipleDevice' object has no attribute 'wallet_view'



    2. test_wallet_send_eth, id: 727229

    Device 1: Swiping right on element SlideButton
    Device 1: Find SlideButton by xpath: //*[@resource-id='slide-button-track'] 

    critical/test_wallet.py:111: in test_wallet_send_eth
    self.wallet_1.send_asset(address=self.receiver['address'], asset_name='Ether', amount=amount_to_send)
../views/wallet_view.py:100: in send_asset
    self.confirm_transaction()
../views/wallet_view.py:87: in confirm_transaction
    self.slide_and_confirm_with_password()
../views/wallet_view.py:81: in slide_and_confirm_with_password
    self.slide_button_track.slide()
../views/base_view.py:257: in slide
    self.swipe_right_on_element(width_percentage=1.3, start_x=100)
../views/base_element.py:308: in swipe_right_on_element
    location, size = self.get_element_coordinates()
../views/base_element.py:294: in get_element_coordinates
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: SlideButton by xpath: `//*[@resource-id='slide-button-track']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Class TestWalletOneDevice:

    1. test_wallet_add_remove_watch_only_account, id: 727232

    Device 1: Text is 0x8d2413447ff297d30bdc475f6d5cb00254685aae
    Device 1: Click system back button 

    critical/test_wallet.py:213: in test_wallet_add_remove_watch_only_account
    self.home_view.driver.fail(
base_test_case.py:178: in fail
    pytest.fail('Device %s: %s' % (self.number, text))
 Device 1: Incorrect address '0x8d2413447ff297d30bdc475f6d5cb00254685aae' is shown when swiping between accounts, expected one is '0x8d2413447ff297d30bdc475f6d5cb00254685aae'



    Device sessions

    Expected to fail tests (3)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495

    # STEP: Change device time so chat will be unmuted by timer
    Device 2: Long press on ChatElement 

    critical/chats/test_group_chat.py:466: in test_group_chat_mute_chat
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Chat is still muted after timeout

    [[Chat is not unmuted after expected time: https://github.com//issues/19627]]

    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 702807

    Device 2: Find Text by xpath: //*[starts-with(@text,'Hey, admin!')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Sent 

    critical/chats/test_group_chat.py:97: in test_group_chat_join_send_text_messages_push
    self.chats[1].chat_element_by_text(message_to_admin).wait_for_status_to_be('Delivered', timeout=120)
../views/chat_view.py:225: in wait_for_status_to_be
    raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status))
 Message status was not changed to Delivered, it's Sent

    [[Issue with a message status - Sent instead of Delivered, https://github.com//issues/20126]]

    Device sessions

    Passed tests (46)

    Click to expand

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    5. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    @pavloburykh
    Copy link
    Contributor

    No more issues from my side, thank you for your amazing work!!! I'll wait for the final e2e results and send PR to merge.

    @churik @Parveshdhull, E2E failures seem to be not related to the PR. So it is ready for merge.

    @pavloburykh pavloburykh moved this from IN TESTING to MERGE in Pipeline for QA May 27, 2024
    @Parveshdhull
    Copy link
    Member Author

    Parveshdhull commented May 27, 2024 •
    edited

    Hi @pavloburykh, @churik, Thank you very much for testing the PR.

    I just realized that I forgot to add the status-go label to the PR. It's a very small 2-line change, but as soon as I will rebase it will pull more changes.

    So as we are close to the release branch cutting,

    • should I rebase with develop and use the tag from that
    • or cherry-pick commit to status-go 0.179.x branch and update status-mobile with that.

    cc @cammellos

    @pavloburykh
    Copy link
    Contributor

    Hey @Parveshdhull! We will need to re-run e2e tests after go branch is rebased in this PR in order to make sure develop go commits will not brake mobile develop after bumping go version.

    @Parveshdhull Parveshdhull mentioned this pull request May 27, 2024
    Closed
    @Parveshdhull Parveshdhull moved this from MERGE to CONTRIBUTOR in Pipeline for QA May 27, 2024
    @Parveshdhull Parveshdhull moved this from MERGE to CONTRIBUTOR in Pipeline for QA May 27, 2024
    @Parveshdhull Parveshdhull moved this from CONTRIBUTOR to E2E Tests in Pipeline for QA May 27, 2024
    @Parveshdhull Parveshdhull moved this from CONTRIBUTOR to E2E Tests in Pipeline for QA May 27, 2024
    @status-im-auto
    Copy link
    Member

    87% of end-end tests have passed

    Total executed tests: 52
Failed tests: 4
Expected to fail tests: 3
Passed tests: 45

    IDs of failed tests: 727230,702783,727229,727232 

    IDs of expected to fail tests: 703495,703503,702807

    Failed tests (4)

    Click to expand
  • Rerun failed tests

    • Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230 
    critical/test_wallet.py:119: in test_wallet_send_asset_from_drawer
    self.wallet_view.navigate_back_to_wallet_view()
 'TestWalletMultipleDevice' object has no attribute 'wallet_view'



    2. test_wallet_send_eth, id: 727229

    Device 1: Swiping right on element SlideButton
    Device 1: Find SlideButton by xpath: //*[@resource-id='slide-button-track'] 

    critical/test_wallet.py:111: in test_wallet_send_eth
    self.wallet_1.send_asset(address=self.receiver['address'], asset_name='Ether', amount=amount_to_send)
../views/wallet_view.py:100: in send_asset
    self.confirm_transaction()
../views/wallet_view.py:87: in confirm_transaction
    self.slide_and_confirm_with_password()
../views/wallet_view.py:81: in slide_and_confirm_with_password
    self.slide_button_track.slide()
../views/base_view.py:257: in slide
    self.swipe_right_on_element(width_percentage=1.3, start_x=100)
../views/base_element.py:308: in swipe_right_on_element
    location, size = self.get_element_coordinates()
../views/base_element.py:294: in get_element_coordinates
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: SlideButton by xpath: `//*[@resource-id='slide-button-track']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

    Device 2: Find Text by xpath: //*[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Sent 

    critical/chats/test_1_1_public_chats.py:614: in test_1_1_chat_is_shown_message_sent_delivered_from_offline
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message status was not changed to Delivered, it's Sent after back up online!



    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_watch_only_account, id: 727232

    Device 1: Text is 0x8d2413447ff297d30bdc475f6d5cb00254685aae
    Device 1: Click system back button 

    critical/test_wallet.py:213: in test_wallet_add_remove_watch_only_account
    self.home_view.driver.fail(
base_test_case.py:178: in fail
    pytest.fail('Device %s: %s' % (self.number, text))
 Device 1: Incorrect address '0x8d2413447ff297d30bdc475f6d5cb00254685aae' is shown when swiping between accounts, expected one is '0x8d2413447ff297d30bdc475f6d5cb00254685aae'



    Device sessions

    Expected to fail tests (3)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495

    # STEP: Change device time so chat will be unmuted by timer
    Device 2: Long press on ChatElement 

    critical/chats/test_group_chat.py:466: in test_group_chat_mute_chat
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Chat is still muted after timeout

    [[Chat is not unmuted after expected time: https://github.com//issues/19627]]

    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 702807

    Device 2: Find Text by xpath: //*[starts-with(@text,'Hey, admin!')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Sent 

    critical/chats/test_group_chat.py:97: in test_group_chat_join_send_text_messages_push
    self.chats[1].chat_element_by_text(message_to_admin).wait_for_status_to_be('Delivered', timeout=120)
../views/chat_view.py:225: in wait_for_status_to_be
    raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status))
 Message status was not changed to Delivered, it's Sent

    [[Issue with a message status - Sent instead of Delivered, https://github.com//issues/20126]]

    Device sessions

    Passed tests (45)

    Click to expand

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    5. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    @Parveshdhull
    Copy link
    Member Author

    @pavloburykh Please can you check e2e test results.

    @pavloburykh
    Copy link
    Contributor

    test_wallet_send_asset_from_drawer

    Thank you @Parveshdhull! E2E failures are not PR related. Ready for merge!

    @pavloburykh pavloburykh moved this from E2E Tests to MERGE in Pipeline for QA May 27, 2024
    @Parveshdhull Parveshdhull merged commit 366fb7b into develop May 27, 2024
    6 checks passed
    Pipeline for QA automation moved this from MERGE to DONE May 27, 2024
    @Parveshdhull Parveshdhull deleted the fix/bridge-messages branch May 27, 2024 10:11
    @status-im-auto
    Copy link
    Member

    81% of end-end tests have passed

    Total executed tests: 52
Failed tests: 7
Expected to fail tests: 3
Passed tests: 42

    IDs of failed tests: 727230,702859,727229,703202,702786,702844,727232 

    IDs of expected to fail tests: 703495,703503,702807

    Failed tests (7)

    Click to expand
  • Rerun failed tests

    • Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_reactions, id: 703202

    Device 1: Find `EmojisNumber` by `xpath`: `//*[starts-with(@text,'This is a test message to check some reactions.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-2']/android.widget.TextView[2]`
    Device 1: Find `EmojisNumber` by `xpath`: `//*[starts-with(@text,'This is a test message to check some reactions.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-2']/android.widget.TextView[2]` 

    critical/chats/test_group_chat.py:121: in test_group_chat_reactions
    message_element.emojis_below_message(emoji="thumbs-up").wait_for_element_text(2)
../views/base_element.py:190: in wait_for_element_text
    self.driver.fail(message if message else "`%s` is not equal to expected `%s` in %s sec" % (
base_test_case.py:178: in fail
    pytest.fail('Device %s: %s' % (self.number, text))
 Device 1: `1` is not equal to expected `2` in 30 sec



    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230 

    critical/test_wallet.py:119: in test_wallet_send_asset_from_drawer
    self.wallet_view.navigate_back_to_wallet_view()
 'TestWalletMultipleDevice' object has no attribute 'wallet_view'



    2. test_wallet_send_eth, id: 727229

    Device 1: Swiping right on element SlideButton
    Device 1: Find SlideButton by xpath: //*[@resource-id='slide-button-track'] 

    critical/test_wallet.py:111: in test_wallet_send_eth
    self.wallet_1.send_asset(address=self.receiver['address'], asset_name='Ether', amount=amount_to_send)
../views/wallet_view.py:100: in send_asset
    self.confirm_transaction()
../views/wallet_view.py:87: in confirm_transaction
    self.slide_and_confirm_with_password()
../views/wallet_view.py:81: in slide_and_confirm_with_password
    self.slide_button_track.slide()
../views/base_view.py:257: in slide
    self.swipe_right_on_element(width_percentage=1.3, start_x=100)
../views/base_element.py:308: in swipe_right_on_element
    location, size = self.get_element_coordinates()
../views/base_element.py:294: in get_element_coordinates
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: SlideButton by xpath: `//*[@resource-id='slide-button-track']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Class TestCommunityMultipleDeviceMerged:

    1. test_community_one_image_send_reply, id: 702859

    Device 2: Find EmojisNumber by xpath: //*[starts-with(@text,'reply to image')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-1']/android.widget.TextView[2]
    Device 2: Element EmojisNumber text is equal to 1 

    critical/chats/test_public_chat_browsing.py:503: in test_community_one_image_send_reply
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Reply message was not received by the sender
E    Image message reaction is not shown for the sender



    Device sessions

    2. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844

    Device 2: Tap on found: SendMessageButton
    Device 1: Getting preview message for link: https://m.youtube.com/watch?v=Je7yErjEVt4 

    critical/chats/test_public_chat_browsing.py:587: in test_community_links_with_previews_github_youtube_twitter_gif_send_enable
    message.wait_for_element(60)
../views/base_element.py:129: in wait_for_element
    raise TimeoutException(
 Device `1`: `PreviewMessage` by` xpath`: `//*[starts-with(@text,'https://m.youtube.com/watch?v=Je7yErjEVt4')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_element



    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_watch_only_account, id: 727232

    Device 1: Text is 0x8d2413447ff297d30bdc475f6d5cb00254685aae
    Device 1: Click system back button 

    critical/test_wallet.py:213: in test_wallet_add_remove_watch_only_account
    self.home_view.driver.fail(
base_test_case.py:178: in fail
    pytest.fail('Device %s: %s' % (self.number, text))
 Device 1: Incorrect address '0x8d2413447ff297d30bdc475f6d5cb00254685aae' is shown when swiping between accounts, expected one is '0x8d2413447ff297d30bdc475f6d5cb00254685aae'



    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_mentions_push_notification, id: 702786

    # STEP: Invited member gets push notification with the mention and tap it
    Device 2: Getting PN by 'user_2' 

    critical/chats/test_public_chat_browsing.py:929: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Push notification with the mention was not received by the invited member



    Device sessions

    Expected to fail tests (3)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495

    # STEP: Change device time so chat will be unmuted by timer
    Device 2: Long press on ChatElement 

    critical/chats/test_group_chat.py:466: in test_group_chat_mute_chat
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Chat is still muted after timeout

    [[Chat is not unmuted after expected time: https://github.com//issues/19627]]

    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 702807

    Device 2: Find Text by xpath: //*[starts-with(@text,'Hey, admin!')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Sent 

    critical/chats/test_group_chat.py:97: in test_group_chat_join_send_text_messages_push
    self.chats[1].chat_element_by_text(message_to_admin).wait_for_status_to_be('Delivered', timeout=120)
../views/chat_view.py:225: in wait_for_status_to_be
    raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status))
 Message status was not changed to Delivered, it's Sent

    [[Issue with a message status - Sent instead of Delivered, https://github.com//issues/20126]]

    Device sessions

    Passed tests (42)

    Click to expand

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    3. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    4. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    5. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    8. test_community_message_edit, id: 702843
    Device sessions

    9. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_leave, id: 702845
    Device sessions

    4. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @flexsurfer flexsurfer flexsurfer approved these changes

    @jo-mut jo-mut jo-mut approved these changes

    @cammellos cammellos Awaiting requested review from cammellos

    @qfrank qfrank Awaiting requested review from qfrank

    Assignees

    @churik churik

    @Parveshdhull Parveshdhull

    Labels
    request-manual-qa status-go Tested - OK
    Projects
    Pipeline for QA
      
    DONE
    Pipeline for QA
    Status: DONE
    Milestone
    No milestone
    6 participants
    @Parveshdhull @status-im-auto @flexsurfer @pavloburykh @churik @jo-mut