Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Community state cannot be changed to failed to fetch #20101

Merged
merged 1 commit into from
May 21, 2024
Merged

fix: Community state cannot be changed to failed to fetch #20101

merged 1 commit into from
May 21, 2024

Conversation

yqrashawn
Copy link
Member

fixes #19249

Summary

fetch community may return nil indicating can't find community in store node

this nil community is not handled in the client side leads to infinity fetching

status-go code at
https://github.com/status-im/status-go/blob/4a1a29b6a5ccf5e87ee9f3ff956904d8d3e5d2fb/protocol/messenger_store_node_request_manager.go#L76

Testing notes

only impacts when failed to fetch community

I use this community for testing https://status.app/c/iyKACkQKB0Rvb2RsZXMSJ0NvbG9yaW5nIHRoZSB3b3JsZCB3aXRoIGpveSDigKIg4bSXIOKAohiYohsiByMxMzFEMkYqAwEhMwM=#zQ3shYSHp7GoiXaauJMnDcjwU2yNjdzpXLosAWapPS4CFxc11

Platforms

  • Android
  • iOS

Steps to test

  • Open community overview through community link

status: ready

@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA May 20, 2024
@yqrashawn
Copy link
Member Author

CleanShot.2024-05-20.at.15.00.31.mp4

@yqrashawn yqrashawn force-pushed the fix/failed-to-fetch-community-state branch from c4b6adc to c35eae2 Compare May 20, 2024 07:01
@yqrashawn yqrashawn self-assigned this May 20, 2024
@status-im-auto
Copy link
Member

status-im-auto commented May 20, 2024 •
edited

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ c35eae2 #2 2024-05-20 07:06:54 ~5 min tests 📄log
✔️ c35eae2 #2 2024-05-20 07:08:49 ~7 min android-e2e 🤖apk 📲
✔️ c35eae2 #2 2024-05-20 07:08:57 ~7 min android 🤖apk 📲
✔️ c35eae2 #2 2024-05-20 07:11:00 ~9 min ios 📱ipa 📲
✔️ d9fa8eb #3 2024-05-21 01:11:03 ~4 min tests 📄log
✔️ d9fa8eb #3 2024-05-21 01:12:45 ~6 min android 🤖apk 📲
✔️ d9fa8eb #3 2024-05-21 01:14:11 ~7 min android-e2e 🤖apk 📲
✔️ d9fa8eb #3 2024-05-21 01:15:21 ~8 min ios 📱ipa 📲

@Parveshdhull Parveshdhull moved this from REVIEW to E2E Tests in Pipeline for QA May 20, 2024
@status-im-auto
Copy link
Member

81% of end-end tests have passed

Total executed tests: 52
Failed tests: 8
Expected to fail tests: 2
Passed tests: 42

IDs of failed tests: 727230,702809,703194,704615,727229,702807,727232,702841 

IDs of expected to fail tests: 703495,703503

Failed tests (8)

Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809

    Device 1: Looking for a message by text: quote reply (one row)
    Device 2: Looking for a message by text: quote reply (one row) 

    critical/chats/test_public_chat_browsing.py:981: in test_community_markdown_support
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 bold text in underscores is not displayed with markdown in community channel for the recipient (device 1)



    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    # STEP: Getting ETH amount in the wallet of the sender before transaction
    Device 1: Find WalletTab by accessibility id: wallet-stack-tab 

    critical/test_wallet.py:119: in test_wallet_send_asset_from_drawer
    sender_balance, receiver_balance, eth_amount_sender, eth_amount_receiver = self._get_balances_before_tx()
critical/test_wallet.py:41: in _get_balances_before_tx
    self.wallet_1.wallet_tab.click()
../views/base_element.py:90: in click
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: WalletTab by accessibility id: `wallet-stack-tab` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    2. test_wallet_send_eth, id: 727229

    Device 1: Swiping right on element SlideButton
    Device 1: Find SlideButton by xpath: //*[@resource-id='slide-button-track'] 

    critical/test_wallet.py:111: in test_wallet_send_eth
    self.wallet_1.send_asset(address=self.receiver['address'], asset_name='Ether', amount=amount_to_send)
../views/wallet_view.py:100: in send_asset
    self.confirm_transaction()
../views/wallet_view.py:87: in confirm_transaction
    self.slide_and_confirm_with_password()
../views/wallet_view.py:81: in slide_and_confirm_with_password
    self.slide_button_track.slide()
../views/base_view.py:257: in slide
    self.swipe_right_on_element(width_percentage=1.3, start_x=100)
../views/base_element.py:308: in swipe_right_on_element
    location, size = self.get_element_coordinates()
../views/base_element.py:294: in get_element_coordinates
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: SlideButton by xpath: `//*[@resource-id='slide-button-track']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807

    Device 2: Find Text by xpath: //*[starts-with(@text,'Hey, admin!')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Sent 

    critical/chats/test_group_chat.py:95: in test_group_chat_join_send_text_messages_push
    self.chats[1].chat_element_by_text(message_to_admin).wait_for_status_to_be('Delivered', timeout=120)
../views/chat_view.py:225: in wait_for_status_to_be
    raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status))
 Message status was not changed to Delivered, it's Sent



    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194

    Device 2: Tap on found: SendMessageButton
    Device 1: Looking for a message by text: reply to gallery 

    critical/chats/test_public_chat_browsing.py:429: in test_community_several_images_send_reply
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Reply message was not received by the sender



    Device sessions

    2. test_community_edit_delete_message_when_offline, id: 704615

    # STEP: Receiver is checking if initial messages were delivered
    Device 1: Looking for a message by text: message to edit 

    critical/chats/test_public_chat_browsing.py:783: in test_community_edit_delete_message_when_offline
    self.channel_1.driver.fail("Message '%s' was not received" % message)
base_test_case.py:178: in fail
    pytest.fail('Device %s: %s' % (self.number, text))
 Device 1: Message 'message to edit' was not received



    Device sessions

    3. test_community_unread_messages_badge, id: 702841

    # STEP: Check new messages badge is shown for community
    Device 1: Click until ChatMessageInput by accessibility id: chat-message-input will be presented 

    critical/chats/test_public_chat_browsing.py:637: in test_community_unread_messages_badge
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 New message community badge is not shown
E    New messages channel badge is not shown on channel



    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_watch_only_account, id: 727232

    Device 1: Text is eth:oeth:arb1:0x8d2413447ff297d30bdc475f6d5cb00254685aae
    Device 1: Click system back button 

    critical/test_wallet.py:212: in test_wallet_add_remove_watch_only_account
    self.home_view.driver.fail(
base_test_case.py:178: in fail
    pytest.fail('Device %s: %s' % (self.number, text))
 Device 1: Incorrect address 'eth:oeth:arb1:0x8d2413447ff297d30bdc475f6d5cb00254685aae' is shown when swiping between accounts, expected one is '0:x:8:d:2:4:1:3:4:4:7:f:f:2:9:7:d:3:0:b:d:c:4:7:5:f:6:d:5:c:b:0:0:2:5:4:6:8:5:a:a:e'



    Device sessions

    Expected to fail tests (2)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495

    # STEP: Change device time so chat will be unmuted by timer
    Device 2: Long press on ChatElement 

    critical/chats/test_group_chat.py:464: in test_group_chat_mute_chat
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Chat is still muted after timeout

    [[Chat is not unmuted after expected time: https://github.com//issues/19627]]

    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (42)

    Click to expand

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    2. test_community_mentions_push_notification, id: 702786
    Device sessions

    3. test_community_leave, id: 702845
    Device sessions

    4. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_one_image_send_reply, id: 702859
    Device sessions

    2. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    3. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    4. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    5. test_community_message_delete, id: 702839
    Device sessions

    6. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    7. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    8. test_community_message_edit, id: 702843
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    @churik churik moved this from E2E Tests to IN TESTING in Pipeline for QA May 20, 2024
    @churik churik self-assigned this May 20, 2024
    @status-im-auto
    Copy link
    Member

    38% of end-end tests have passed

    Total executed tests: 8
Failed tests: 5
Expected to fail tests: 0
Passed tests: 3

    IDs of failed tests: 704615,727230,727229,702807,727232

    Failed tests (5)

    Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMerged:

    1. test_community_edit_delete_message_when_offline, id: 704615

    Device 1: Looking for a message by text: message to edit
    Device 1: Looking for a message by text: message to delete 

    critical/chats/test_public_chat_browsing.py:783: in test_community_edit_delete_message_when_offline
    self.channel_1.driver.fail("Message '%s' was not received" % message)
base_test_case.py:178: in fail
    pytest.fail('Device %s: %s' % (self.number, text))
 Device 1: Message 'message to delete' was not received



    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    # STEP: Getting ETH amount in the wallet of the sender before transaction
    Device 1: Find WalletTab by accessibility id: wallet-stack-tab 

    critical/test_wallet.py:119: in test_wallet_send_asset_from_drawer
    sender_balance, receiver_balance, eth_amount_sender, eth_amount_receiver = self._get_balances_before_tx()
critical/test_wallet.py:41: in _get_balances_before_tx
    self.wallet_1.wallet_tab.click()
../views/base_element.py:90: in click
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: WalletTab by accessibility id: `wallet-stack-tab` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    2. test_wallet_send_eth, id: 727229

    Device 1: Swiping right on element SlideButton
    Device 1: Find SlideButton by xpath: //*[@resource-id='slide-button-track'] 

    critical/test_wallet.py:111: in test_wallet_send_eth
    self.wallet_1.send_asset(address=self.receiver['address'], asset_name='Ether', amount=amount_to_send)
../views/wallet_view.py:100: in send_asset
    self.confirm_transaction()
../views/wallet_view.py:87: in confirm_transaction
    self.slide_and_confirm_with_password()
../views/wallet_view.py:81: in slide_and_confirm_with_password
    self.slide_button_track.slide()
../views/base_view.py:257: in slide
    self.swipe_right_on_element(width_percentage=1.3, start_x=100)
../views/base_element.py:308: in swipe_right_on_element
    location, size = self.get_element_coordinates()
../views/base_element.py:294: in get_element_coordinates
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: SlideButton by xpath: `//*[@resource-id='slide-button-track']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807

    Device 2: Find Text by xpath: //*[starts-with(@text,'Hey, admin!')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Sent 

    critical/chats/test_group_chat.py:95: in test_group_chat_join_send_text_messages_push
    self.chats[1].chat_element_by_text(message_to_admin).wait_for_status_to_be('Delivered', timeout=120)
../views/chat_view.py:225: in wait_for_status_to_be
    raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status))
 Message status was not changed to Delivered, it's Sent



    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_watch_only_account, id: 727232

    Device 1: Text is eth:oeth:arb1:0x8d2413447ff297d30bdc475f6d5cb00254685aae
    Device 1: Click system back button 

    critical/test_wallet.py:212: in test_wallet_add_remove_watch_only_account
    self.home_view.driver.fail(
base_test_case.py:178: in fail
    pytest.fail('Device %s: %s' % (self.number, text))
 Device 1: Incorrect address 'eth:oeth:arb1:0x8d2413447ff297d30bdc475f6d5cb00254685aae' is shown when swiping between accounts, expected one is '0:x:8:d:2:4:1:3:4:4:7:f:f:2:9:7:d:3:0:b:d:c:4:7:5:f:6:d:5:c:b:0:0:2:5:4:6:8:5:a:a:e'



    Device sessions

    Passed tests (3)

    Click to expand

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    @churik
    Copy link
    Member

    churik commented May 20, 2024

    Hello!
    The e2e results are reviewed, the failed tests are not related to the PR.
    Tested redirect to the page from different places, success / fail flows - works like a charm.
    PR can proceed to the next stage.

    Thank you for the quality work!

    @churik churik moved this from IN TESTING to MERGE in Pipeline for QA May 20, 2024
    @yqrashawn
    fix: Community state cannot be changed to failed to fetch
    d9fa8eb 
    Signed-off-by: yqrashawn <namy.19@gmail.com>
    @yqrashawn yqrashawn force-pushed the fix/failed-to-fetch-community-state branch from c35eae2 to d9fa8eb Compare May 21, 2024 01:06
    @yqrashawn yqrashawn merged commit b358c06 into develop May 21, 2024
    6 checks passed
    Pipeline for QA automation moved this from MERGE to DONE May 21, 2024
    @yqrashawn yqrashawn deleted the fix/failed-to-fetch-community-state branch May 21, 2024 01:16
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @Parveshdhull Parveshdhull Parveshdhull approved these changes

    @ibrkhalil ibrkhalil ibrkhalil approved these changes

    Assignees

    @churik churik

    @yqrashawn yqrashawn

    Labels
    request-manual-qa Tested - OK
    Projects
    Pipeline for QA
      
    DONE
    Pipeline for QA
    Status: DONE
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Community state cannot be changed to 'Failed to fetch community'
    5 participants
    @yqrashawn @status-im-auto @churik @Parveshdhull @ibrkhalil