-
-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: improve README examples of lib/node_modules/@stdlib/constants/u… #2097
base: develop
Are you sure you want to change the base?
Conversation
…nicode I have read and understood the Code of Conduct. Searched for existing issues and pull requests. The issue name begins with RFC:. Signed-off-by: Muhammad Farjad <86410882+BeastMasterGrinder@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hi there! 👋
And thank you for opening your first pull request! We will review it shortly. 🏃 💨
@@ -22,21 +22,33 @@ limitations under the License. | |||
|
|||
> Unicode constants. | |||
|
|||
<section class="usage"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this removed?
``` | ||
|
||
#### constants |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this change made? Where else in the project do we make the API heading level 2?
|
||
// Maximum Unicode code point: | ||
console.log( 'Maximum Unicode code point:', constants.MAX ); | ||
|
||
// Maximum Basic Multilingual Plane (BMP) code point: | ||
console.log( 'Maximum BMP code point:', constants.MAX_BMP ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first code block is always the import. Please see other packages in the project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR makes several changes we don't want and does not conform to existing project conventions/practices. As such, we won't be able to move this forward until changes are made.
Resolves #1566 .
Description
Related Issues
This pull request:
constants/unicode
namespace #1566constants/unicode
namespace #1566Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers