Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Update podspec to include privacy manifest #1265

Conversation

SagarSDagdu
Copy link
Contributor

@SagarSDagdu SagarSDagdu commented Apr 18, 2024

What does this PR do

  • Although the source code has a privacy manifest, it is not being included in the pod dependency. Hence, it is not being downloaded to the client app's pods. I have updated the podspec to include it as a resource bundle (this is a standard practice to include resources)
  • Update the marketing version to the upcoming release version.

Closes #1263

@SagarSDagdu
Copy link
Contributor Author

SagarSDagdu commented Apr 18, 2024

@nathanfallet Please create a new release as soon as you get to merge this, as clients using the library via Cocoapods are not getting privacy manifest file as of 0.15.2

I have also incremented the marketing version 0.15.3 for the upcoming release.

For recent releases, the `Info.plist` shipped inside the `xcframeworks` do not match the release version. Fixing that to reflect the marketing version we will be releasing next.
Update `podspec` to include privacy manifest
@SagarSDagdu SagarSDagdu force-pushed the privacy-manifest-inclusion-in-podspec branch from 9751ff5 to 5d3db22 Compare April 18, 2024 16:20
@SagarSDagdu SagarSDagdu changed the title Update podspec to include privacy manifest Bugfix: Update podspec to include privacy manifest Apr 18, 2024
@nathanfallet
Copy link
Collaborator

Thanks, I did not know it had to be included in the podspec too to be available

@nathanfallet nathanfallet merged commit 966344c into stephencelis:master Apr 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PrivacyInfo.xcprivacy
2 participants