Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working with bullet points was reworked to fix some glitches #4636

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

HoffmannTom
Copy link
Contributor

What does this PR do?

Working with bullet points was sometimes problematic when whitespaces were present.
Copy & Paste also caused some trouble.
This PR modifies the bullet point functions For this to work, the dom and range class were extended by adding some helper functions.

Where should the reviewer start?

  • best is to start with dom.js and range.js and check the additional methods.
  • bullet.js contains major changes

How should this be manually tested?

  • use the editor to create and modify lists (OL / UL)

Any background context you want to provide?

If a

  • element contains formattings or additional elements (div, span), the splitNode function doesn't work well and creates some additional lines or refuses to split. This needs to be addressed in the future. The splitNode function was not modified by this PR.

    What are the relevant tickets?

    Screenshot (if for frontend)

    Checklist

    • Added relevant tests or not required
    • Didn't break anything
  • The range object was extended to allow modification of start and end point. Furthermore, the child nodes can be fetched as a list by recursively walking the DOM.
    The bullet.js was modified to get along better with whitespaces
    @HoffmannTom HoffmannTom mentioned this pull request May 5, 2024
    6 tasks
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    None yet

    2 participants