Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adjust copy in addon update modal for partner billing[GEN-8953] #26306

Merged
merged 1 commit into from
May 16, 2024

Conversation

ecktoteckto
Copy link
Contributor

@ecktoteckto ecktoteckto commented May 14, 2024

Removes sentences like

“Upon clicking confirm, the amount of $10 will be added to your monthly invoice. For the current billing cycle you'll be charged a prorated amount at the end of the cycle.”

from the addon modal for both billing partners "AWS" and "Fly".
Reason is that this text is confusing given that we don't provide/send out monthly invoices to customers billed via a partner and we want to simplify things.

Additional:
I aligned the texts for the IPv4 addon with the other addons.

  1. The text "Upon clicking confirm, the add-on is removed..." is not displayed for partner billed customers
  2. The text "Upon clicking confirm, the respective amount will be added to your monthly invoice..." is displayed for non partner billed customers. We use the word "respective" instead of an exact amount because its $4 for each Read replica. This additional text not necessarily makes the modal arranged more clearly but I thought it would be better to be consistent across addons.
Screenshot 2024-05-15 at 17 45 29

Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
studio-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 4:01pm
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
database-new ⬜️ Ignored (Inspect) May 15, 2024 4:01pm
docs ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 4:01pm
studio ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 4:01pm
studio-self-hosted ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 4:01pm
zone-www-dot-com ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 4:01pm

Copy link

supabase bot commented May 14, 2024

No changes detected in supabase directory.
This pull request has been ignored for the connected project xguihxuzqibwxjnimxev due to its connection settings.
Go to Project Integrations Settings ↗︎ in order to change this behavior.


Branching Preview Branches by Supabase.
Learn more about Supabase for Git ↗︎.

Copy link

@kevcodez kevcodez merged commit 7f61132 into master May 16, 2024
16 checks passed
@kevcodez kevcodez deleted the chore/addon-update-modal-copy branch May 16, 2024 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants