feat: render mgmt api body params #26319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
|
No changes detected in Branching Preview Branches by Supabase. |
phamhieu
commented
May 15, 2024
apps/docs/components/Options.tsx
Outdated
| </span> | ||
| <span className="text-foreground-muted text-xs">{props.type ?? 'no type'}</span> | ||
| </span>} | ||
| {!props.isEnum && <span className="text-foreground-muted text-xs">{props.type ?? 'no type'}</span>} |
There was a problem hiding this comment.
I have to add a new prop to prevent require and type fields rendering. It looks weir for accepted enum values
phamhieu
commented
May 15, 2024
phamhieu
requested review from
fsansalvadore,
MildTomato and
alaister
and removed request for
fsansalvadore,
MildTomato and
alaister
charislam
approved these changes
May 21, 2024
Co-authored-by: Charis <26616127+charislam@users.noreply.github.com>
Co-authored-by: Charis <26616127+charislam@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have read the CONTRIBUTING.md file.
YES
What kind of change does this PR introduce?
Mgmt api docs doesn't show body params
What is the current behavior?
Body params is empty
What is the new behavior?
Body params will be rendered
Additional context