Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Options" component border radius transition and padding #26332

Conversation

andreaselia
Copy link
Contributor

@andreaselia andreaselia commented May 15, 2024

I have read the CONTRIBUTING.md file.

YES

What kind of change does this PR introduce?

"Options" component fixes.

What is the current behaviour?

The border radius has a visible delay when transitioning.

The icon and text move when opening due to different padding then the closed state.

What is the new behaviour?

The border radius instantly changes.

The icon and text no longer move and have the same padding as the closed state.

Additional context

Before (video):

supa-before.mp4

After (video):

supa-after.mp4

Copy link

vercel bot commented May 15, 2024

@andreaselia is attempting to deploy a commit to the Supabase Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@charislam charislam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andreaselia!

@charislam charislam enabled auto-merge (squash) May 22, 2024 01:57
Copy link

vercel bot commented May 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ❌ Failed (Inspect) May 22, 2024 2:06am
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 2:06am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
studio ⬜️ Ignored (Inspect) Visit Preview May 22, 2024 2:06am
studio-self-hosted ⬜️ Ignored (Inspect) Visit Preview May 22, 2024 2:06am
studio-staging ⬜️ Ignored (Inspect) Visit Preview May 22, 2024 2:06am
zone-www-dot-com ⬜️ Ignored (Inspect) Visit Preview May 22, 2024 2:06am

@charislam charislam merged commit 4a2a68b into supabase:master May 22, 2024
13 of 14 checks passed
@andreaselia andreaselia deleted the andreaselia/fix-options-border-and-padding branch May 22, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants